ModernUO/Projects/UOContent/Skills
Kamron Batman f77dd91811
fix: Overhauls virtue system (#1376)
## MAJOR CHANGE (API BREAKING)

Moved the virtues to it's own system _VirtueSystem_. This should make it easier to extend or remove the virtue system. Virtues will be saved to a new folder called _Virtues_.

### Motivation

The motivation was also two-fold, performance/stability, and to fix bugs.

First, virtues is the second system (first is murders), that has a pre-world-save check on _every mobile in the game_ to atrophy virtue stats. This is taxing since it freexes the world and makes world saves take longer. Every mobile had Gain/Loss dates for each virtue, whether they needed them or not. Most players don't even use the virtue system, so this will increase performance considerably.

Second, when I tried to optimize/refactor the code, I found several bugs that needed to be fixed.

### Major API Changes

- [X] The properties on players related to virtues are gone. Use `pm.GetVirtues()?.<PropertyName>` instead.
- [X] Virtues were removed from non-player Mobiles.
- [X] `pm.JusticeProtectors` was removed. Use `JusticeVirtue.GetProtector()` or `JusticeVirtue.GetProtected()` instead.

### Screenshots

<img width="221" alt="Props-1" src="https://github.com/modernuo/ModernUO/assets/3953314/5c09cb83-b8d5-44a2-b899-a7ed7cd736ac">
<img width="220" alt="props-2" src="https://github.com/modernuo/ModernUO/assets/3953314/aeade4d3-8df0-47bd-955a-a864d0946cf7">
2023-07-19 21:43:47 -07:00
..
Tracking feat: Moves skills to json file (#1411) 2023-06-16 05:55:55 -07:00
Anatomy.cs fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
AnimalLore.cs Fixes brace style (#248) 2020-09-13 21:49:46 -07:00
AnimalTaming.cs fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
AntiMacroSystem.cs fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
ArmsLore.cs fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
Begging.cs fix: Fixes tick count calculcations (#1366) 2023-03-09 21:00:17 -08:00
DetectHidden.cs chore(content): Updates to C# 9 syntax (#373) 2020-12-30 12:50:10 -08:00
Discordance.cs fix: Adds name support for all mods (#1128) 2022-10-15 10:46:31 -07:00
EvalInt.cs fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
ForensicEval.cs fix: Fixes string interpolation in value string builder (#1339) 2023-02-13 23:09:50 -08:00
Hiding.cs fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
Inscribe.cs chore: Cleans up pattern checks. (#892) 2021-12-24 15:53:59 -08:00
ItemIdentification.cs Removes literal variables (#257) 2020-09-18 18:41:26 -07:00
Meditation.cs fix: Cleanup IPoint3D calls (#704) 2021-08-19 09:11:48 -07:00
Peacemaking.cs chore: Cleans up pattern checks. (#892) 2021-12-24 15:53:59 -08:00
Poisoning.cs chore: Cleans up pattern checks. (#892) 2021-12-24 15:53:59 -08:00
Provocation.cs fix: Fixes provocation for pre-pub 16 (#1335) 2023-02-07 23:33:45 -08:00
RemoveTrap.cs fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
SkillCheck.cs fix: Overhauls antimacro system (#1403) 2023-05-19 16:32:51 -07:00
SkillsInfo.cs feat: Moves skills to json file (#1411) 2023-06-16 05:55:55 -07:00
Snooping.cs fix: Fixes snooping staff (#900) 2021-12-28 02:09:25 -08:00
SpiritSpeak.cs fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
Stealing.cs fix: Updates disguises and codegens tinkering items (#1353) 2023-02-25 12:01:06 -08:00
Stealth.cs fix: Updates races to properly support gargoyle equipment. (#744) 2021-08-29 00:43:55 -07:00
TasteID.cs Removes literal variables (#257) 2020-09-18 18:41:26 -07:00