ModernUO/Projects/Server/Mobiles
Kamron Batman ecbee17690
fix: Optimizes OPL using string interpolation (#1041)
## Breaking Changes (New API)
ObjectPropertyList supports the following API:
```cs
list.Add(500000);
list.Add(500001, stringArgument);
list.Add("Some text");
list.Add($"Some text with {argument}");
list.Add(500002, $"{arg1}\t{arg2}");
```

## Notes
1. All API uses that require a formatter like this:
    ```cs
    list.Add(500002, "{0}\t{1}", arg1, arg2);
    ```
    Should be changed to use string interpolation, for example:
    ```cs
    list.Add(500002, $"{arg1}\t{arg2}");
    ```
2. The following paradigm should no longer be used:
    ```cs
    list.Add(1061170, prop.ToString()); // strength requirement ~1_val~
    ```
    The new string interpolation API will avoid having to convert the argument to a string before writing it to the packet. Instead use the following:
    ```cs
    list.Add(1061170, $"{prop}"); // strength requirement ~1_val~
    ```

### Benchmarks
```cs
|                         Method |     Mean |   Error |  StdDev |  Gen 0 | Allocated |
|------------------------------- |---------:|--------:|--------:|-------:|----------:|
|                BenchmarkOldOPL | 241.0 ns | 0.56 ns | 0.47 ns | 0.0105 |      88 B |
| BenchmarkStringInterpolatedOPL | 199.9 ns | 2.44 ns | 2.39 ns |      - |         - |
```

### Changes
- [X] Removes crash in STArray.Return when array is null.
- [X] Fixes NPE in OPL when entity is null. Serial in packet will be 0 when entity is null.
- [X] Fixes NPE in AosAttributes when Parent is null.
- [X] Changes OPL to use string interpolation.
- [X] Introduces `IPropertyList` to allow extending PropertyList for other uses.
2022-06-02 10:09:53 -07:00
..
AggressorInfo.cs fix(core): Caches DateTime.NowUtc (#548) 2021-03-13 01:32:04 -08:00
BaseVendor.cs Cleanup/Housekeeping (#242) 2020-09-12 15:31:21 -07:00
Body.cs fix: Removes BodyValue and fixes modifying Body and BodyMod in props gump. (#743) 2021-08-28 22:56:00 -07:00
IMount.cs Cleanup/Housekeeping (#242) 2020-09-12 15:31:21 -07:00
IVendor.cs Cleanup/Housekeeping (#242) 2020-09-12 15:31:21 -07:00
Mobile.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
Movement.cs fix: Simplifies fastwalk detection (#907) 2022-02-27 02:20:03 -08:00
Notoriety.cs Cleanup/Housekeeping (#242) 2020-09-12 15:31:21 -07:00
SimplePrompt.cs Splits up mobile (#296) 2020-10-31 23:30:51 -07:00
SimpleTarget.cs Splits up mobile (#296) 2020-10-31 23:30:51 -07:00