ModernUO/Projects/Server/Network
Kamron Batman ecbee17690
fix: Optimizes OPL using string interpolation (#1041)
## Breaking Changes (New API)
ObjectPropertyList supports the following API:
```cs
list.Add(500000);
list.Add(500001, stringArgument);
list.Add("Some text");
list.Add($"Some text with {argument}");
list.Add(500002, $"{arg1}\t{arg2}");
```

## Notes
1. All API uses that require a formatter like this:
    ```cs
    list.Add(500002, "{0}\t{1}", arg1, arg2);
    ```
    Should be changed to use string interpolation, for example:
    ```cs
    list.Add(500002, $"{arg1}\t{arg2}");
    ```
2. The following paradigm should no longer be used:
    ```cs
    list.Add(1061170, prop.ToString()); // strength requirement ~1_val~
    ```
    The new string interpolation API will avoid having to convert the argument to a string before writing it to the packet. Instead use the following:
    ```cs
    list.Add(1061170, $"{prop}"); // strength requirement ~1_val~
    ```

### Benchmarks
```cs
|                         Method |     Mean |   Error |  StdDev |  Gen 0 | Allocated |
|------------------------------- |---------:|--------:|--------:|-------:|----------:|
|                BenchmarkOldOPL | 241.0 ns | 0.56 ns | 0.47 ns | 0.0105 |      88 B |
| BenchmarkStringInterpolatedOPL | 199.9 ns | 2.44 ns | 2.39 ns |      - |         - |
```

### Changes
- [X] Removes crash in STArray.Return when array is null.
- [X] Fixes NPE in OPL when entity is null. Serial in packet will be 0 when entity is null.
- [X] Fixes NPE in AosAttributes when Parent is null.
- [X] Changes OPL to use string interpolation.
- [X] Introduces `IPropertyList` to allow extending PropertyList for other uses.
2022-06-02 10:09:53 -07:00
..
NetState fix: Fixes issue with wepoll losing GCHandle. (#1039) 2022-05-30 14:04:54 -07:00
Packets fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
ContainerGridPacketHandler.cs fix: Fixes packet length checks (#953) 2022-03-04 12:32:25 -08:00
EncodedPacketHandler.cs Renames pvSrc (#277) 2020-10-17 22:04:44 -07:00
EncodedReader.cs Update Readers/Writers for Buffers & Fixes bugs (#283) 2020-10-24 14:46:59 -07:00
NetworkCompression.cs fix: Fixes code genning armor, clothing, and BODs (#810) 2021-09-28 22:09:34 -07:00
PacketHandler.cs fix: Fixes packet length checks (#953) 2022-03-04 12:32:25 -08:00
PacketUtilities.cs fix: Cleans up mobile status packets (#835) 2022-02-27 03:10:35 -08:00
Pipe.cs fix(serialization): Updates serialization flow & fixes serializing accounts (#521) 2021-02-24 22:14:15 -08:00
ServerInfo.cs fix(core): Fixes IPMatch and some cleanup (#443) 2021-02-03 14:31:02 -08:00
TcpServer.cs fix: Adds better client verification (#853) 2021-11-27 10:06:39 -08:00