ModernUO/Projects/UOContent/Engines/CannedEvil
Kamron Batman ecbee17690
fix: Optimizes OPL using string interpolation (#1041)
## Breaking Changes (New API)
ObjectPropertyList supports the following API:
```cs
list.Add(500000);
list.Add(500001, stringArgument);
list.Add("Some text");
list.Add($"Some text with {argument}");
list.Add(500002, $"{arg1}\t{arg2}");
```

## Notes
1. All API uses that require a formatter like this:
    ```cs
    list.Add(500002, "{0}\t{1}", arg1, arg2);
    ```
    Should be changed to use string interpolation, for example:
    ```cs
    list.Add(500002, $"{arg1}\t{arg2}");
    ```
2. The following paradigm should no longer be used:
    ```cs
    list.Add(1061170, prop.ToString()); // strength requirement ~1_val~
    ```
    The new string interpolation API will avoid having to convert the argument to a string before writing it to the packet. Instead use the following:
    ```cs
    list.Add(1061170, $"{prop}"); // strength requirement ~1_val~
    ```

### Benchmarks
```cs
|                         Method |     Mean |   Error |  StdDev |  Gen 0 | Allocated |
|------------------------------- |---------:|--------:|--------:|-------:|----------:|
|                BenchmarkOldOPL | 241.0 ns | 0.56 ns | 0.47 ns | 0.0105 |      88 B |
| BenchmarkStringInterpolatedOPL | 199.9 ns | 2.44 ns | 2.39 ns |      - |         - |
```

### Changes
- [X] Removes crash in STArray.Return when array is null.
- [X] Fixes NPE in OPL when entity is null. Serial in packet will be 0 when entity is null.
- [X] Fixes NPE in AosAttributes when Parent is null.
- [X] Changes OPL to use string interpolation.
- [X] Introduces `IPropertyList` to allow extending PropertyList for other uses.
2022-06-02 10:09:53 -07:00
..
CannedEvilTimer.cs fix(core): Adds Hashed & Hierarchical Timer Wheel (#655) 2021-07-11 22:42:06 -07:00
ChampionAltar.cs feat(champs): Ports Casiopia champions (#584) 2021-05-09 00:20:43 -07:00
ChampionCommands.cs feat(champs): Ports Casiopia champions (#584) 2021-05-09 00:20:43 -07:00
ChampionPlatform.cs feat(champs): Ports Casiopia champions (#584) 2021-05-09 00:20:43 -07:00
ChampionSkull.cs feat(champs): Ports Casiopia champions (#584) 2021-05-09 00:20:43 -07:00
ChampionSkullBrazier.cs feat(champs): Ports Casiopia champions (#584) 2021-05-09 00:20:43 -07:00
ChampionSkullPlatform.cs feat(champs): Ports Casiopia champions (#584) 2021-05-09 00:20:43 -07:00
ChampionSkullType.cs feat(champs): Ports Casiopia champions (#584) 2021-05-09 00:20:43 -07:00
ChampionSpawn.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
ChampionSpawnType.cs feat(champs): Ports Casiopia champions (#584) 2021-05-09 00:20:43 -07:00
DungeonChampionSpawn.cs cleanup: Fixes bugs and cleans up code (#660) 2021-07-19 20:49:59 -07:00
GenChampEntry.cs feat(champs): Ports Casiopia champions (#584) 2021-05-09 00:20:43 -07:00
GenChamps.cs feat(champs): Ports Casiopia champions (#584) 2021-05-09 00:20:43 -07:00
HarrowerGate.cs fix(core): Fixes several serialization issues (#355) 2020-12-23 07:11:41 -08:00
LLChampionSpawn.cs feat(champs): Ports Casiopia champions (#584) 2021-05-09 00:20:43 -07:00
StarRoomGate.cs fix(core): Caches DateTime.NowUtc (#548) 2021-03-13 01:32:04 -08:00