ecbee17690
## Breaking Changes (New API)
ObjectPropertyList supports the following API:
```cs
list.Add(500000);
list.Add(500001, stringArgument);
list.Add("Some text");
list.Add($"Some text with {argument}");
list.Add(500002, $"{arg1}\t{arg2}");
```
## Notes
1. All API uses that require a formatter like this:
```cs
list.Add(500002, "{0}\t{1}", arg1, arg2);
```
Should be changed to use string interpolation, for example:
```cs
list.Add(500002, $"{arg1}\t{arg2}");
```
2. The following paradigm should no longer be used:
```cs
list.Add(1061170, prop.ToString()); // strength requirement ~1_val~
```
The new string interpolation API will avoid having to convert the argument to a string before writing it to the packet. Instead use the following:
```cs
list.Add(1061170, $"{prop}"); // strength requirement ~1_val~
```
### Benchmarks
```cs
| Method | Mean | Error | StdDev | Gen 0 | Allocated |
|------------------------------- |---------:|--------:|--------:|-------:|----------:|
| BenchmarkOldOPL | 241.0 ns | 0.56 ns | 0.47 ns | 0.0105 | 88 B |
| BenchmarkStringInterpolatedOPL | 199.9 ns | 2.44 ns | 2.39 ns | - | - |
```
### Changes
- [X] Removes crash in STArray.Return when array is null.
- [X] Fixes NPE in OPL when entity is null. Serial in packet will be 0 when entity is null.
- [X] Fixes NPE in AosAttributes when Parent is null.
- [X] Changes OPL to use string interpolation.
- [X] Introduces `IPropertyList` to allow extending PropertyList for other uses.
88 lines
2.2 KiB
C#
88 lines
2.2 KiB
C#
using Server.Gumps;
|
|
using Server.Network;
|
|
|
|
namespace Server.Engines.Quests.Collector
|
|
{
|
|
public class PaintedImage : Item
|
|
{
|
|
private ImageType m_Image;
|
|
|
|
[Constructible]
|
|
public PaintedImage(ImageType image) : base(0xFF3)
|
|
{
|
|
Weight = 1.0;
|
|
Hue = 0x8FD;
|
|
|
|
m_Image = image;
|
|
}
|
|
|
|
public PaintedImage(Serial serial) : base(serial)
|
|
{
|
|
}
|
|
|
|
[CommandProperty(AccessLevel.GameMaster)]
|
|
public ImageType Image
|
|
{
|
|
get => m_Image;
|
|
set
|
|
{
|
|
m_Image = value;
|
|
InvalidateProperties();
|
|
}
|
|
}
|
|
|
|
public override void AddNameProperty(IPropertyList list)
|
|
{
|
|
var info = ImageTypeInfo.Get(m_Image);
|
|
list.Add(1060847, $"#1055126\t#{info.Name}"); // a painted image of:
|
|
}
|
|
|
|
public override void OnSingleClick(Mobile from)
|
|
{
|
|
var info = ImageTypeInfo.Get(m_Image);
|
|
LabelTo(from, 1060847, $"#1055126\t#{info.Name}"); // a painted image of:
|
|
}
|
|
|
|
public override void OnDoubleClick(Mobile from)
|
|
{
|
|
if (!from.InRange(GetWorldLocation(), 2))
|
|
{
|
|
from.LocalOverheadMessage(MessageType.Regular, 0x3B2, 1019045); // I can't reach that.
|
|
return;
|
|
}
|
|
|
|
from.SendGump(new InternalGump(m_Image));
|
|
}
|
|
|
|
public override void Serialize(IGenericWriter writer)
|
|
{
|
|
base.Serialize(writer);
|
|
|
|
writer.Write(0); // version
|
|
|
|
writer.WriteEncodedInt((int)m_Image);
|
|
}
|
|
|
|
public override void Deserialize(IGenericReader reader)
|
|
{
|
|
base.Deserialize(reader);
|
|
|
|
var version = reader.ReadInt();
|
|
|
|
m_Image = (ImageType)reader.ReadEncodedInt();
|
|
}
|
|
|
|
private class InternalGump : Gump
|
|
{
|
|
public InternalGump(ImageType image) : base(75, 25)
|
|
{
|
|
var info = ImageTypeInfo.Get(image);
|
|
|
|
AddBackground(45, 20, 100, 100, 0xA3C);
|
|
AddBackground(52, 29, 86, 82, 0xBB8);
|
|
|
|
AddItem(info.X, info.Y, info.Figurine);
|
|
}
|
|
}
|
|
}
|
|
}
|