warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
ModernUO/Projects/UOContent/Items/Addons
History
Kamron Batman ecbee17690
fix: Optimizes OPL using string interpolation (#1041) 
## Breaking Changes (New API)
ObjectPropertyList supports the following API:
```cs
list.Add(500000);
list.Add(500001, stringArgument);
list.Add("Some text");
list.Add($"Some text with {argument}");
list.Add(500002, $"{arg1}\t{arg2}");
```

## Notes
1. All API uses that require a formatter like this:
    ```cs
    list.Add(500002, "{0}\t{1}", arg1, arg2);
    ```
    Should be changed to use string interpolation, for example:
    ```cs
    list.Add(500002, $"{arg1}\t{arg2}");
    ```
2. The following paradigm should no longer be used:
    ```cs
    list.Add(1061170, prop.ToString()); // strength requirement ~1_val~
    ```
    The new string interpolation API will avoid having to convert the argument to a string before writing it to the packet. Instead use the following:
    ```cs
    list.Add(1061170, $"{prop}"); // strength requirement ~1_val~
    ```

### Benchmarks
```cs
|                         Method |     Mean |   Error |  StdDev |  Gen 0 | Allocated |
|------------------------------- |---------:|--------:|--------:|-------:|----------:|
|                BenchmarkOldOPL | 241.0 ns | 0.56 ns | 0.47 ns | 0.0105 |      88 B |
| BenchmarkStringInterpolatedOPL | 199.9 ns | 2.44 ns | 2.39 ns |      - |         - |
```

### Changes
- [X] Removes crash in STArray.Return when array is null.
- [X] Fixes NPE in OPL when entity is null. Serial in packet will be 0 when entity is null.
- [X] Fixes NPE in AosAttributes when Parent is null.
- [X] Changes OPL to use string interpolation.
- [X] Introduces `IPropertyList` to allow extending PropertyList for other uses.
2022-06-02 10:09:53 -07:00
..
AbbatoirAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
AddonComponent.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
AddonContainerComponent.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
AlchemistTableEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
AlchemistTableSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
AnvilEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
AnvilSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ArcaneBookshelfEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ArcaneBookshelfSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ArcaneCircleAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ArcanistStatueEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ArcanistStatueSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ArcheryButteAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
BallotBox.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
BaseAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
BaseAddonContainer.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
BaseAddonContainerDeed.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
BaseAddonDeed.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
BearRugs.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
BloodPentagram.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
DartBoard.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenBedEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenBedSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenDresserEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenDresserSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenForgeAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenLoveseatEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenLoveseatSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenSpinningWheelEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenSpinningwheelSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenStoveEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenStoveSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenWashbasinEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenWashbasinSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
FancyElvenTableEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
FancyElvenTableSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
FireColumnAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
FlourMillEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
FlourMillSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
FlowerTapestries.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
GiantWebs.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
GozaMats.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
GrayBrickFireplaceEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
GrayBrickFireplaceSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
JackOLantern.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
LargeBedEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
LargeBedSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
LargeForgeEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
LargeForgeSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
LargeStoneTableEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
LargeStoneTableSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
LoomEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
LoomSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
MediumStoneTableEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
MediumStoneTableSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
OrnateElvenChestEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
OrnateElvenChestSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
OrnateElvenTableEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
OrnateElvenTableSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ParrotPerchAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
PentagramAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
PickpocketDips.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
PyramidAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
RejuvinationAnkhs.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SandstoneFireplaceEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SandstoneFireplaceSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SandstoneFountainAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SerpentPillarAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ShrineOfWisdomAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SHTeleporter.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SkullPileAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SmallBedEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SmallBedSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SmallForgeAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SolenAntHole.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SpinningwheelEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SpinningwheelSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SquirrelStatueEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SquirrelStatueSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
StoneFireplaceEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
StoneFireplaceSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
StoneFountainAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
StoneOvenEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
StoneOvenSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
StretchedHides.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
TallElvenBedEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
TallElvenBedSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
Telescope.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
TrainingDummies.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
WarriorStatueEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
WarriorStatueSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
WaterTroughEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
WaterTroughSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
WaterVat.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00