ecbee17690
## Breaking Changes (New API)
ObjectPropertyList supports the following API:
```cs
list.Add(500000);
list.Add(500001, stringArgument);
list.Add("Some text");
list.Add($"Some text with {argument}");
list.Add(500002, $"{arg1}\t{arg2}");
```
## Notes
1. All API uses that require a formatter like this:
```cs
list.Add(500002, "{0}\t{1}", arg1, arg2);
```
Should be changed to use string interpolation, for example:
```cs
list.Add(500002, $"{arg1}\t{arg2}");
```
2. The following paradigm should no longer be used:
```cs
list.Add(1061170, prop.ToString()); // strength requirement ~1_val~
```
The new string interpolation API will avoid having to convert the argument to a string before writing it to the packet. Instead use the following:
```cs
list.Add(1061170, $"{prop}"); // strength requirement ~1_val~
```
### Benchmarks
```cs
| Method | Mean | Error | StdDev | Gen 0 | Allocated |
|------------------------------- |---------:|--------:|--------:|-------:|----------:|
| BenchmarkOldOPL | 241.0 ns | 0.56 ns | 0.47 ns | 0.0105 | 88 B |
| BenchmarkStringInterpolatedOPL | 199.9 ns | 2.44 ns | 2.39 ns | - | - |
```
### Changes
- [X] Removes crash in STArray.Return when array is null.
- [X] Fixes NPE in OPL when entity is null. Serial in packet will be 0 when entity is null.
- [X] Fixes NPE in AosAttributes when Parent is null.
- [X] Changes OPL to use string interpolation.
- [X] Introduces `IPropertyList` to allow extending PropertyList for other uses.
122 lines
3.3 KiB
C#
122 lines
3.3 KiB
C#
using ModernUO.Serialization;
|
|
|
|
namespace Server.Items
|
|
{
|
|
[Flippable]
|
|
[SerializationGenerator(1)]
|
|
public partial class LeafGloves : BaseArmor, IArcaneEquip
|
|
{
|
|
private int _maxArcaneCharges;
|
|
private int _curArcaneCharges;
|
|
|
|
[Constructible]
|
|
public LeafGloves() : base(0x2FC6) => Weight = 2.0;
|
|
|
|
public override int RequiredRaces => Race.AllowElvesOnly;
|
|
public override int BasePhysicalResistance => 2;
|
|
public override int BaseFireResistance => 3;
|
|
public override int BaseColdResistance => 2;
|
|
public override int BasePoisonResistance => 4;
|
|
public override int BaseEnergyResistance => 4;
|
|
|
|
public override int InitMinHits => 30;
|
|
public override int InitMaxHits => 40;
|
|
|
|
public override int AosStrReq => 10;
|
|
public override int OldStrReq => 10;
|
|
|
|
public override int ArmorBase => 13;
|
|
|
|
public override ArmorMaterialType MaterialType => ArmorMaterialType.Leather;
|
|
public override CraftResource DefaultResource => CraftResource.RegularLeather;
|
|
|
|
public override ArmorMeditationAllowance DefMedAllowance => ArmorMeditationAllowance.All;
|
|
|
|
[EncodedInt]
|
|
[SerializableField(0)]
|
|
[CommandProperty(AccessLevel.GameMaster)]
|
|
public int CurArcaneCharges
|
|
{
|
|
get => _curArcaneCharges;
|
|
set
|
|
{
|
|
_curArcaneCharges = value;
|
|
InvalidateProperties();
|
|
Update();
|
|
}
|
|
}
|
|
|
|
[EncodedInt]
|
|
[SerializableField(1)]
|
|
[CommandProperty(AccessLevel.GameMaster)]
|
|
public int MaxArcaneCharges
|
|
{
|
|
get => _maxArcaneCharges;
|
|
set
|
|
{
|
|
_maxArcaneCharges = value;
|
|
InvalidateProperties();
|
|
Update();
|
|
}
|
|
}
|
|
|
|
[CommandProperty(AccessLevel.GameMaster)]
|
|
public bool IsArcane => _maxArcaneCharges > 0 && _curArcaneCharges >= 0;
|
|
|
|
private void Deserialize(IGenericReader reader, int version)
|
|
{
|
|
if (reader.ReadBool())
|
|
{
|
|
_curArcaneCharges = reader.ReadInt();
|
|
_maxArcaneCharges = reader.ReadInt();
|
|
}
|
|
}
|
|
|
|
public void Update()
|
|
{
|
|
if (IsArcane)
|
|
{
|
|
ItemID = 0x26B0; // TODO: Check
|
|
}
|
|
else if (ItemID == 0x26B0)
|
|
{
|
|
ItemID = 0x2FC6;
|
|
}
|
|
|
|
if (IsArcane && CurArcaneCharges == 0)
|
|
{
|
|
Hue = 0;
|
|
}
|
|
}
|
|
|
|
public override void GetProperties(IPropertyList list)
|
|
{
|
|
base.GetProperties(list);
|
|
|
|
if (IsArcane)
|
|
{
|
|
list.Add(1061837, $"{_curArcaneCharges}\t{_maxArcaneCharges}"); // arcane charges: ~1_val~ / ~2_val~
|
|
}
|
|
}
|
|
|
|
public override void OnSingleClick(Mobile from)
|
|
{
|
|
base.OnSingleClick(from);
|
|
|
|
if (IsArcane)
|
|
{
|
|
LabelTo(from, 1061837, $"{_curArcaneCharges}\t{_maxArcaneCharges}");
|
|
}
|
|
}
|
|
|
|
public void Flip()
|
|
{
|
|
ItemID = ItemID switch
|
|
{
|
|
0x2FC6 => 0x317C,
|
|
0x317C => 0x2FC6,
|
|
_ => ItemID
|
|
};
|
|
}
|
|
}
|
|
}
|