84153fba58
## Why Delta world saves re-serialize an entity only when it has been marked dirty. An audit of the generated classes found three ways serialized state changes without a mark; this PR closes the ones that do not need a new generator package. ## What - **Custom `[SerializableProperty]` setters mark dirty.** Twelve hand-written setters assigned their backing field without `this.MarkDirty()`. `PlagueBeastLord.OpenedBy` was an auto-property carrying the attribute with no backing field at all; it is now a generated field with the same name, order and command-property exposure. - **Generated sub-objects are linked to their owner.** Without a `[DirtyTrackingEntity]` member the generator emits setters that mark nothing. Eight entity-owned sub-objects now carry the link and receive the owner through the constructor the generator calls: `BOBFilter` (owner is `IEntity`: a `PlayerMobile` or a `BulkOrderBook`), `BOBLargeSubEntry`, `PuzzleChestSolution` and `PuzzleChestSolutionAndTime`, `TalismanAttribute` (the random factories now take the talisman), `VendorItem`, `PlayerBBMessage`, `RaffleEntry`, `ShardPollOption`. Migration schemas were regenerated with the pinned tool; the only change is the value rule argument becoming `DeserializationRequiresParent`. - **BaseVendor uses the generator; restock amounts are no longer persisted.** The only state it wrote was which buy entries had grown restock amounts, packed by index into the live `SBInfos` tables. Restock is transient now and rebuilds on load; version 1 records are read and discarded through the legacy path. Every vendor subclass now serializes through a generated chain. ## Generator 4.1.0 This PR adopts SerializationGenerator 4.1.0 (modernuo/SerializationGenerator#55): SG3019/SG3020 diagnostics, `[VolatileSerializedState]`, `StopXxx()` timer helpers, and owner-constructor preference for sub-objects (so dictionary values are constructed with their owner; the 4.0.0 relink fallback is gone). `PlayerVendor.v3.json` gains `DeserializationRequiresParent` for its `VendorItem` values so the migration content struct constructs them with their vendor. SG3019 is an error under `TreatWarningsAsErrors` and generator diagnostics ignore pragmas, so the five contexts that live in whole-file player-keyed persistences (`ChampionTitle`, `ChampionTitleContext`, `MurderContext`, `VirtueContext`, `JailRecord`) now carry a `[DirtyTrackingEntity]` link to their `PlayerMobile`, which is where they will live once those blobs move onto the player record. `JailSystem.EmptyRecord` keeps a null player (`[CanBeNull]`). `ChampionTitle` needs both a context and a player constructor because the generator resolves the rule against the containing type but emits the call with the parent field; a comment in the file records this. ## Wire format Unchanged. No version bumps except `BaseVendor` 1 to 2 (which now writes nothing of its own). Schema diffs are rule-argument only (`DeserializationRequiresParent`). ## Testing Server.Tests 848 passed, UOContent.Tests 759 passed.
83 lines
2.3 KiB
C#
83 lines
2.3 KiB
C#
using ModernUO.Serialization;
|
|
|
|
namespace Server.Engines.BulkOrders;
|
|
|
|
[SerializationGenerator(1)]
|
|
public partial class BOBLargeEntry : BaseBOBEntry
|
|
{
|
|
[SerializableField(0, setter: "private")]
|
|
private BOBLargeSubEntry[] _entries;
|
|
|
|
public BOBLargeEntry(LargeBOD bod)
|
|
{
|
|
RequireExceptional = bod.RequireExceptional;
|
|
|
|
DeedType = bod switch
|
|
{
|
|
LargeTailorBOD => BODType.Tailor,
|
|
LargeSmithBOD => BODType.Smith,
|
|
_ => DeedType
|
|
};
|
|
|
|
Material = bod.Material;
|
|
AmountMax = bod.AmountMax;
|
|
|
|
_entries = new BOBLargeSubEntry[bod.Entries.Length];
|
|
|
|
for (var i = 0; i < _entries.Length; ++i)
|
|
{
|
|
_entries[i] = new BOBLargeSubEntry(this, bod.Entries[i]);
|
|
}
|
|
}
|
|
|
|
public override Item Reconstruct()
|
|
{
|
|
LargeBOD bod = DeedType switch
|
|
{
|
|
BODType.Smith => new LargeSmithBOD(AmountMax, RequireExceptional, Material, ReconstructEntries()),
|
|
BODType.Tailor => new LargeTailorBOD(AmountMax, RequireExceptional, Material, ReconstructEntries()),
|
|
_ => null
|
|
};
|
|
|
|
for (var i = 0; i < bod?.Entries.Length; ++i)
|
|
{
|
|
bod.Entries[i].Owner = bod;
|
|
}
|
|
|
|
return bod;
|
|
}
|
|
|
|
private LargeBulkEntry[] ReconstructEntries()
|
|
{
|
|
var entries = new LargeBulkEntry[Entries.Length];
|
|
|
|
for (var i = 0; i < Entries.Length; ++i)
|
|
{
|
|
entries[i] = new LargeBulkEntry(
|
|
null,
|
|
new SmallBulkEntry(Entries[i].ItemType, Entries[i].Number, Entries[i].Graphic)
|
|
)
|
|
{ Amount = Entries[i].AmountCur };
|
|
}
|
|
|
|
return entries;
|
|
}
|
|
|
|
private void Deserialize(IGenericReader reader, int version)
|
|
{
|
|
RequireExceptional = reader.ReadBool();
|
|
|
|
DeedType = (BODType)reader.ReadEncodedInt();
|
|
Material = (BulkMaterialType)reader.ReadEncodedInt();
|
|
AmountMax = reader.ReadEncodedInt();
|
|
Price = reader.ReadEncodedInt();
|
|
|
|
_entries = new BOBLargeSubEntry[reader.ReadEncodedInt()];
|
|
|
|
for (var i = 0; i < Entries.Length; ++i)
|
|
{
|
|
_entries[i] = new BOBLargeSubEntry(this);
|
|
_entries[i].Deserialize(reader);
|
|
}
|
|
}
|
|
}
|