ModernUO/Projects/UOContent/Spells/Spellweaving
Kamron Batman ecbee17690
fix: Optimizes OPL using string interpolation (#1041)
## Breaking Changes (New API)
ObjectPropertyList supports the following API:
```cs
list.Add(500000);
list.Add(500001, stringArgument);
list.Add("Some text");
list.Add($"Some text with {argument}");
list.Add(500002, $"{arg1}\t{arg2}");
```

## Notes
1. All API uses that require a formatter like this:
    ```cs
    list.Add(500002, "{0}\t{1}", arg1, arg2);
    ```
    Should be changed to use string interpolation, for example:
    ```cs
    list.Add(500002, $"{arg1}\t{arg2}");
    ```
2. The following paradigm should no longer be used:
    ```cs
    list.Add(1061170, prop.ToString()); // strength requirement ~1_val~
    ```
    The new string interpolation API will avoid having to convert the argument to a string before writing it to the packet. Instead use the following:
    ```cs
    list.Add(1061170, $"{prop}"); // strength requirement ~1_val~
    ```

### Benchmarks
```cs
|                         Method |     Mean |   Error |  StdDev |  Gen 0 | Allocated |
|------------------------------- |---------:|--------:|--------:|-------:|----------:|
|                BenchmarkOldOPL | 241.0 ns | 0.56 ns | 0.47 ns | 0.0105 |      88 B |
| BenchmarkStringInterpolatedOPL | 199.9 ns | 2.44 ns | 2.39 ns |      - |         - |
```

### Changes
- [X] Removes crash in STArray.Return when array is null.
- [X] Fixes NPE in OPL when entity is null. Serial in packet will be 0 when entity is null.
- [X] Fixes NPE in AosAttributes when Parent is null.
- [X] Changes OPL to use string interpolation.
- [X] Introduces `IPropertyList` to allow extending PropertyList for other uses.
2022-06-02 10:09:53 -07:00
..
Items fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
Mobiles fix: Removes scale speed by dex for monsters, fixes NPC movement/thinking speed (#1019) 2022-05-15 10:01:14 -07:00
ArcaneCircle.cs chore: Cleans up pattern checks. (#892) 2021-12-24 15:53:59 -08:00
ArcaneForm.cs Fixes brace style (#248) 2020-09-13 21:49:46 -07:00
ArcaneSummon.cs Fixes dupe exception (#258) 2020-09-19 15:46:07 -07:00
ArcanistSpell.cs fix: Removes from literals (#893) 2021-12-24 15:56:07 -08:00
AttuneWeapon.cs fix: More spell variable cleanup (#850) 2021-11-14 18:48:44 -08:00
EssenceOfWind.cs fix: More spell variable cleanup (#850) 2021-11-14 18:48:44 -08:00
EtherealVoyage.cs fix: Cleans up spell info variable (#848) 2021-11-14 18:31:32 -08:00
GiftOfLife.cs fix: More spell variable cleanup (#850) 2021-11-14 18:48:44 -08:00
GiftOfRenewal.cs fix: More spell variable cleanup (#850) 2021-11-14 18:48:44 -08:00
ImmolatingWeapon.cs chore: Cleans up pattern checks. (#892) 2021-12-24 15:53:59 -08:00
NatureFury.cs fix: Cleans up spell info variable (#848) 2021-11-14 18:31:32 -08:00
ReaperForm.cs fix: Cleans up spell info variable (#848) 2021-11-14 18:31:32 -08:00
SummonFey.cs fix: Cleans up spell info variable (#848) 2021-11-14 18:31:32 -08:00
SummonFiend.cs fix: Cleans up spell info variable (#848) 2021-11-14 18:31:32 -08:00
Thunderstorm.cs fix: More spell variable cleanup (#850) 2021-11-14 18:48:44 -08:00
WordOfDeath.cs fix: Removes duplicative spell checks (#849) 2021-11-14 18:45:16 -08:00