ModernUO/Projects/UOContent/Spells
Kamron Batman ecbee17690
fix: Optimizes OPL using string interpolation (#1041)
## Breaking Changes (New API)
ObjectPropertyList supports the following API:
```cs
list.Add(500000);
list.Add(500001, stringArgument);
list.Add("Some text");
list.Add($"Some text with {argument}");
list.Add(500002, $"{arg1}\t{arg2}");
```

## Notes
1. All API uses that require a formatter like this:
    ```cs
    list.Add(500002, "{0}\t{1}", arg1, arg2);
    ```
    Should be changed to use string interpolation, for example:
    ```cs
    list.Add(500002, $"{arg1}\t{arg2}");
    ```
2. The following paradigm should no longer be used:
    ```cs
    list.Add(1061170, prop.ToString()); // strength requirement ~1_val~
    ```
    The new string interpolation API will avoid having to convert the argument to a string before writing it to the packet. Instead use the following:
    ```cs
    list.Add(1061170, $"{prop}"); // strength requirement ~1_val~
    ```

### Benchmarks
```cs
|                         Method |     Mean |   Error |  StdDev |  Gen 0 | Allocated |
|------------------------------- |---------:|--------:|--------:|-------:|----------:|
|                BenchmarkOldOPL | 241.0 ns | 0.56 ns | 0.47 ns | 0.0105 |      88 B |
| BenchmarkStringInterpolatedOPL | 199.9 ns | 2.44 ns | 2.39 ns |      - |         - |
```

### Changes
- [X] Removes crash in STArray.Return when array is null.
- [X] Fixes NPE in OPL when entity is null. Serial in packet will be 0 when entity is null.
- [X] Fixes NPE in AosAttributes when Parent is null.
- [X] Changes OPL to use string interpolation.
- [X] Introduces `IPropertyList` to allow extending PropertyList for other uses.
2022-06-02 10:09:53 -07:00
..
Base fix: Cleans up LINQ calls. (#965) 2022-03-20 19:20:54 -07:00
Bushido fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
Chivalry fix: Cleans up LINQ calls. (#965) 2022-03-20 19:20:54 -07:00
Eighth fix: Cleans up LINQ calls. (#965) 2022-03-20 19:20:54 -07:00
Fifth fix: Cleans up LINQ calls. (#965) 2022-03-20 19:20:54 -07:00
First fix: Fixes skill requirements and cleans up magery spells (#870) 2021-12-05 09:40:57 -08:00
Fourth fix: Cleans up LINQ calls. (#965) 2022-03-20 19:20:54 -07:00
Gargoyle/SpellDefinitions fix: Cleans up spell info variable (#848) 2021-11-14 18:31:32 -08:00
Mysticism fix: More spell variable cleanup (#850) 2021-11-14 18:48:44 -08:00
Necromancy fix: Fixes first/second scrolls crashing (#891) 2021-12-24 15:26:12 -08:00
Ninjitsu fix: Removes scale speed by dex for monsters, fixes NPC movement/thinking speed (#1019) 2022-05-15 10:01:14 -07:00
Second fix: Fixes skill requirements and cleans up magery spells (#870) 2021-12-05 09:40:57 -08:00
Seventh fix: Cleans up LINQ calls. (#965) 2022-03-20 19:20:54 -07:00
Sixth fix: Cleans up LINQ calls. (#965) 2022-03-20 19:20:54 -07:00
Spellweaving fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
Targeting fix: Fixes targeting checks (#869) 2021-12-01 08:15:16 -08:00
Third fix: Codegens lockable containers and cleans up lockpickable (#976) 2022-03-26 21:48:18 -07:00
Initializer.cs fix: Changes spells so they register during configuration (#889) 2021-12-19 19:58:59 -08:00
Reagent.cs Formats UO Content (#201) 2020-08-27 18:30:38 -07:00
UnsummonTimer.cs fix(core): Adds Hashed & Hierarchical Timer Wheel (#655) 2021-07-11 22:42:06 -07:00