Updates Packets & Randomizer (#43)

* Fixes a bug with the main loop. Removes unnecessary optimizations for RDRand.

* WIP - Rewriting packets.

* Cleanup and updates README

* Converts more packets

* Fixes header

* Converts Effects packets.

* Forgot the send command

* Adds the start of containers packets.

* Adds message packets with caching

* Extends the send methods

* Starts to add Acquire methods

* Converted the packets

* Cleanup

* Cleanup

* Adds more packets

* Adds more packets

* Fixes clearing arrays from pool. Adds Mobile Incoming

* Converts more packets.

* Moves more packets

* Moves more packets

* Test compression

* Merges

* Migrating to an idiomatic syntax that also supports compression, and proxying.

* Optimize the stack alloc. Changes attributes

* Converted container packets

* Visual Studio doesn't auto save files. I am still getting used to subpar IDEs.

* Adds static packet caching. Will profile later. Converts more packets

* Fixes packets and changes how compression is configured

* WIP - Adds basics for Gumps. Not finished though.

* Fix file

* Fixes formatting

* Changed SpanWriter to be more idiomatic.

* Fixes Span vs RawSpan and missing stackallocs

* Converts over some more gumps

* WIP - Deletes 32bit support.

* Drops RDRand32 support.

* Fixes gump compilation

* Converting gump components

* Removes old huffman compression function

* Revert signature for backwards compatibility

* WIP - Converting more gump components

* Creates ArraySet for the strings. Updates AppendTo to reference that.

* Converts the maining gump components

* Cleans up gump components

* Cleans up directives

* Cleans up ArraySet and moves it. Adds null-coalescing-assignment

* Cleanup, Target Packets, and C# 8 changes.

* Removed OPL Packet

* World packets

* Fixing packet uses

* Cleans up code. Fixes packet uses in various places.

* More cleanup for packets

* Code cleanup

* Converts more packet uses and cleans up more code

* More code cleanup

* Finishes fixing the packets in Item

* Updates secure trade packets

* Updates core and gets it to compile.

* Moved packets to scripts. Fixed account handler use of packets

* Code cleanup

* Updates chat packets

* Code cleanuo

* Adds party packets, but need to implement them.

* Party packets WIP

* Finishes party packets

* Rearrange movement namespaces and classes

* Finishes plant packets

* Code Formatting

* Fixes moving effects

* Code cleanup, eliminates equipinfo

* Adds more packets. Fixes bugs with various packets.

* Finishes mahjon packets

* Fixes mahjong packet

* Code cleanup

* Finishes mahjong packets

* Adds Map packets

* Add multifacet maps and charts

* Cleans up some packets with UTF8

* Optimizes packets

* Cleans up more packets. Moves the MessageHelper

* Removes assistant support. Removes extended protocol. Incorporates MapUO packets as normal packets.

* Updates protocol extensions packet receiver

* Fixes a few bugs. Fixes a few more packets.

* Code cleanup and fixing more packets

* Fixes packet effects

* Cleaned up more code

* Buff Icon cleanup

* Removed unused constructors

* Code Cleanup. Adds BoatHS Packets

* Moves house files. Updates house foundation packets.

* Deployment cleanup

* Fixes:

* Code cleanup

* More code cleanup

* More code cleanup

* Cleaned up BaseHouse

* Enforces styling

* Converts foreach to linq where possible.

* Dont need that

* Goals/Readme updates

* Removes 32bit support at the highest level. Turns on HRT by default.

* Code cleanup. Fixes extended features packet.

* Fixes various bugs

* Code cleanup

* Code cleanup

* Code cleanup. Fixes gump X/Y assignment.

* Code cleanup using |= operator

* More code cleanup

* Cleanup

* Fixes spacing issues. Thanks Visual Studio. You suck.

* Compiler error

* Fixes NPE from RunUO 2.7

* Renames ScriptCompiler to AssemblyHandler. Fixes packets. Updates README

* Fixes more packets. Stupid trailing nulls.

* Fixes various bugs.

* Fixes for gumps

* Fixes more gump stuff. Going to split it out later since it is getting insane

* Recoded the gump writing

* WIP

* *Added output path of scripts project to dev branch
*Activated debugging in code

Projects/Scripts/Gumps/Props/PropsGump.cs

@@ -153,9 +153,7 @@ namespace Server.Gumps
 
       if (parent != null)
       {
-        if (m_Stack == null)
-          m_Stack = new Stack<StackEntry>();
-
+        m_Stack ??= new Stack<StackEntry>();
         m_Stack.Push(parent);
       }
 
@@ -281,9 +279,9 @@ namespace Server.Gumps
       }
     }
 
-    public override void OnResponse(NetState state, RelayInfo info)
+    public override void OnResponse(NetState sender, RelayInfo info)
     {
-      Mobile from = state.Mobile;
+      Mobile from = sender.Mobile;
 
       if (!BaseCommand.IsAccessible(from, m_Object))
       {

Projects/Scripts/Gumps/Props/SetBodyGump.cs

@@ -127,7 +127,6 @@ namespace Server.Gumps
         switch (index)
         {
           default:
-          case 0:
             type = ModelBodyType.Monsters;
             list = m_Monster;
             break;
@@ -204,24 +203,17 @@ namespace Server.Gumps
         if (((Body)bodyID).IsEmpty)
           continue;
 
-        List<InternalEntry> list;
-
-        switch (oldEntry.BodyType)
+        List<InternalEntry> list = oldEntry.BodyType switch
         {
-          default: continue;
-          case ModelBodyType.Monsters:
-            list = m_Monster;
-            break;
-          case ModelBodyType.Animals:
-            list = m_Animal;
-            break;
-          case ModelBodyType.Sea:
-            list = m_Sea;
-            break;
-          case ModelBodyType.Human:
-            list = m_Human;
-            break;
-        }
+          ModelBodyType.Monsters => m_Monster,
+          ModelBodyType.Animals => m_Animal,
+          ModelBodyType.Sea => m_Sea,
+          ModelBodyType.Human => m_Human,
+          _ => null
+        };
+
+        if (list == null)
+          return;
 
         int itemID = ShrinkTable.Lookup(bodyID, -1);
 
@@ -287,7 +279,7 @@ namespace Server.Gumps
         int v = Name.CompareTo(comp.Name);
 
         if (v == 0)
-          Body.CompareTo(comp.Body);
+          v = Body.CompareTo(comp.Body);
 
         return v;
       }

Projects/Scripts/Gumps/Props/SetGump.cs

@@ -1,7 +1,6 @@
 using System.Collections.Generic;
 using System.Reflection;
 using Server.Commands;
-using Server.HuePickers;
 using Server.Network;
 
 namespace Server.Gumps

Projects/Scripts/Gumps/Props/SetObjectGump.cs

@@ -4,7 +4,6 @@ using System.Reflection;
 using Server.Commands;
 using Server.Commands.Generic;
 using Server.Network;
-using Server.Prompts;
 
 namespace Server.Gumps
 {