Updates Packets & Randomizer (#43)

* Fixes a bug with the main loop. Removes unnecessary optimizations for RDRand.

* WIP - Rewriting packets.

* Cleanup and updates README

* Converts more packets

* Fixes header

* Converts Effects packets.

* Forgot the send command

* Adds the start of containers packets.

* Adds message packets with caching

* Extends the send methods

* Starts to add Acquire methods

* Converted the packets

* Cleanup

* Cleanup

* Adds more packets

* Adds more packets

* Fixes clearing arrays from pool. Adds Mobile Incoming

* Converts more packets.

* Moves more packets

* Moves more packets

* Test compression

* Merges

* Migrating to an idiomatic syntax that also supports compression, and proxying.

* Optimize the stack alloc. Changes attributes

* Converted container packets

* Visual Studio doesn't auto save files. I am still getting used to subpar IDEs.

* Adds static packet caching. Will profile later. Converts more packets

* Fixes packets and changes how compression is configured

* WIP - Adds basics for Gumps. Not finished though.

* Fix file

* Fixes formatting

* Changed SpanWriter to be more idiomatic.

* Fixes Span vs RawSpan and missing stackallocs

* Converts over some more gumps

* WIP - Deletes 32bit support.

* Drops RDRand32 support.

* Fixes gump compilation

* Converting gump components

* Removes old huffman compression function

* Revert signature for backwards compatibility

* WIP - Converting more gump components

* Creates ArraySet for the strings. Updates AppendTo to reference that.

* Converts the maining gump components

* Cleans up gump components

* Cleans up directives

* Cleans up ArraySet and moves it. Adds null-coalescing-assignment

* Cleanup, Target Packets, and C# 8 changes.

* Removed OPL Packet

* World packets

* Fixing packet uses

* Cleans up code. Fixes packet uses in various places.

* More cleanup for packets

* Code cleanup

* Converts more packet uses and cleans up more code

* More code cleanup

* Finishes fixing the packets in Item

* Updates secure trade packets

* Updates core and gets it to compile.

* Moved packets to scripts. Fixed account handler use of packets

* Code cleanup

* Updates chat packets

* Code cleanuo

* Adds party packets, but need to implement them.

* Party packets WIP

* Finishes party packets

* Rearrange movement namespaces and classes

* Finishes plant packets

* Code Formatting

* Fixes moving effects

* Code cleanup, eliminates equipinfo

* Adds more packets. Fixes bugs with various packets.

* Finishes mahjon packets

* Fixes mahjong packet

* Code cleanup

* Finishes mahjong packets

* Adds Map packets

* Add multifacet maps and charts

* Cleans up some packets with UTF8

* Optimizes packets

* Cleans up more packets. Moves the MessageHelper

* Removes assistant support. Removes extended protocol. Incorporates MapUO packets as normal packets.

* Updates protocol extensions packet receiver

* Fixes a few bugs. Fixes a few more packets.

* Code cleanup and fixing more packets

* Fixes packet effects

* Cleaned up more code

* Buff Icon cleanup

* Removed unused constructors

* Code Cleanup. Adds BoatHS Packets

* Moves house files. Updates house foundation packets.

* Deployment cleanup

* Fixes:

* Code cleanup

* More code cleanup

* More code cleanup

* Cleaned up BaseHouse

* Enforces styling

* Converts foreach to linq where possible.

* Dont need that

* Goals/Readme updates

* Removes 32bit support at the highest level. Turns on HRT by default.

* Code cleanup. Fixes extended features packet.

* Fixes various bugs

* Code cleanup

* Code cleanup

* Code cleanup. Fixes gump X/Y assignment.

* Code cleanup using |= operator

* More code cleanup

* Cleanup

* Fixes spacing issues. Thanks Visual Studio. You suck.

* Compiler error

* Fixes NPE from RunUO 2.7

* Renames ScriptCompiler to AssemblyHandler. Fixes packets. Updates README

* Fixes more packets. Stupid trailing nulls.

* Fixes various bugs.

* Fixes for gumps

* Fixes more gump stuff. Going to split it out later since it is getting insane

* Recoded the gump writing

* WIP

* *Added output path of scripts project to dev branch
*Activated debugging in code

Projects/Scripts/Items/Talismans/TalismanSlayer.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using Server.Mobiles;
 
 namespace Server.Items
@@ -73,9 +74,7 @@ namespace Server.Items
         },
         [TalismanSlayerName.Bovine] = new[]
         {
-          typeof(Cow), typeof(Bull), typeof(Gaman) /*, typeof( MinotaurCaptain ),
-				  typeof( MinotaurScout ), typeof( Minotaur )*/
-          // TODO TormentedMinotaur
+          typeof(Cow), typeof(Bull), typeof(Gaman), typeof(TormentedMinotaur)
         }
       };
     }
@@ -83,15 +82,11 @@ namespace Server.Items
     public static bool Slays(TalismanSlayerName name, Mobile m)
     {
       if (m == null || !m_Table.TryGetValue(name, out Type[] types) || types == null)
-        return false;;
+        return false;
 
       Type type = m.GetType();
 
-      for (int i = 0; i < types.Length; i++)
-        if (types[i].IsAssignableFrom(type))
-          return true;
-
-      return false;
+      return types.Any(t => t.IsAssignableFrom(type));
     }
   }
 }

Projects/Scripts/Items/Talismans/TalismanSummons.cs

@@ -2,6 +2,7 @@ using System;
 using System.Collections.Generic;
 using Server.ContextMenus;
 using Server.Items;
+using Server.Regions;
 
 namespace Server.Mobiles
 {
@@ -396,9 +397,6 @@ namespace Server.Mobiles
       int version = reader.ReadEncodedInt();
     }
 
-    /*
-    // An area attack that only damages staff, wtf?
-
     private DateTime m_NextWave;
 
     public void AreaHeatDamage()
@@ -408,29 +406,20 @@ namespace Server.Mobiles
       if ( mob != null )
       {
         if ( mob.InRange( Location, 2 ) )
-        {
-          if ( mob.AccessLevel != AccessLevel.Player )
+          if ( mob.AccessLevel == AccessLevel.Player )
           {
             AOS.Damage( mob, Utility.Random( 2, 3 ), 0, 100, 0, 0, 0 );
             mob.SendLocalizedMessage( 1008112 ); // The intense heat is damaging you!
           }
-        }
 
-        GuardedRegion r = Region as GuardedRegion;
-
-        if ( r != null && mob.Alive )
-        {
+        if ( Region is GuardedRegion && mob.Alive )
           foreach ( Mobile m in GetMobilesInRange( 2 ) )
-          {
             if ( !mob.CanBeHarmful( m ) )
               mob.CriminalAction( false );
-          }
-        }
       }
 
       m_NextWave = DateTime.UtcNow + TimeSpan.FromSeconds( 3 );
     }
-    */
   }
 
   public class SummonedOrcBrute : BaseTalismanSummon
@@ -631,4 +620,4 @@ namespace Server.Mobiles
       int version = reader.ReadEncodedInt();
     }
   }
-}
+}