Updates Packets & Randomizer (#43)

* Fixes a bug with the main loop. Removes unnecessary optimizations for RDRand.

* WIP - Rewriting packets.

* Cleanup and updates README

* Converts more packets

* Fixes header

* Converts Effects packets.

* Forgot the send command

* Adds the start of containers packets.

* Adds message packets with caching

* Extends the send methods

* Starts to add Acquire methods

* Converted the packets

* Cleanup

* Cleanup

* Adds more packets

* Adds more packets

* Fixes clearing arrays from pool. Adds Mobile Incoming

* Converts more packets.

* Moves more packets

* Moves more packets

* Test compression

* Merges

* Migrating to an idiomatic syntax that also supports compression, and proxying.

* Optimize the stack alloc. Changes attributes

* Converted container packets

* Visual Studio doesn't auto save files. I am still getting used to subpar IDEs.

* Adds static packet caching. Will profile later. Converts more packets

* Fixes packets and changes how compression is configured

* WIP - Adds basics for Gumps. Not finished though.

* Fix file

* Fixes formatting

* Changed SpanWriter to be more idiomatic.

* Fixes Span vs RawSpan and missing stackallocs

* Converts over some more gumps

* WIP - Deletes 32bit support.

* Drops RDRand32 support.

* Fixes gump compilation

* Converting gump components

* Removes old huffman compression function

* Revert signature for backwards compatibility

* WIP - Converting more gump components

* Creates ArraySet for the strings. Updates AppendTo to reference that.

* Converts the maining gump components

* Cleans up gump components

* Cleans up directives

* Cleans up ArraySet and moves it. Adds null-coalescing-assignment

* Cleanup, Target Packets, and C# 8 changes.

* Removed OPL Packet

* World packets

* Fixing packet uses

* Cleans up code. Fixes packet uses in various places.

* More cleanup for packets

* Code cleanup

* Converts more packet uses and cleans up more code

* More code cleanup

* Finishes fixing the packets in Item

* Updates secure trade packets

* Updates core and gets it to compile.

* Moved packets to scripts. Fixed account handler use of packets

* Code cleanup

* Updates chat packets

* Code cleanuo

* Adds party packets, but need to implement them.

* Party packets WIP

* Finishes party packets

* Rearrange movement namespaces and classes

* Finishes plant packets

* Code Formatting

* Fixes moving effects

* Code cleanup, eliminates equipinfo

* Adds more packets. Fixes bugs with various packets.

* Finishes mahjon packets

* Fixes mahjong packet

* Code cleanup

* Finishes mahjong packets

* Adds Map packets

* Add multifacet maps and charts

* Cleans up some packets with UTF8

* Optimizes packets

* Cleans up more packets. Moves the MessageHelper

* Removes assistant support. Removes extended protocol. Incorporates MapUO packets as normal packets.

* Updates protocol extensions packet receiver

* Fixes a few bugs. Fixes a few more packets.

* Code cleanup and fixing more packets

* Fixes packet effects

* Cleaned up more code

* Buff Icon cleanup

* Removed unused constructors

* Code Cleanup. Adds BoatHS Packets

* Moves house files. Updates house foundation packets.

* Deployment cleanup

* Fixes:

* Code cleanup

* More code cleanup

* More code cleanup

* Cleaned up BaseHouse

* Enforces styling

* Converts foreach to linq where possible.

* Dont need that

* Goals/Readme updates

* Removes 32bit support at the highest level. Turns on HRT by default.

* Code cleanup. Fixes extended features packet.

* Fixes various bugs

* Code cleanup

* Code cleanup

* Code cleanup. Fixes gump X/Y assignment.

* Code cleanup using |= operator

* More code cleanup

* Cleanup

* Fixes spacing issues. Thanks Visual Studio. You suck.

* Compiler error

* Fixes NPE from RunUO 2.7

* Renames ScriptCompiler to AssemblyHandler. Fixes packets. Updates README

* Fixes more packets. Stupid trailing nulls.

* Fixes various bugs.

* Fixes for gumps

* Fixes more gump stuff. Going to split it out later since it is getting insane

* Recoded the gump writing

* WIP

* *Added output path of scripts project to dev branch
*Activated debugging in code

Projects/Server/Persistence/BinaryMemoryWriter.cs

@@ -20,7 +20,7 @@
 
 using System.IO;
 
-namespace Server
+namespace Server.Persistence
 {
   public sealed class BinaryMemoryWriter : BinaryFileWriter
   {

Projects/Server/Persistence/DualSaveStrategy.cs

@@ -20,7 +20,7 @@
 
 using System.Threading;
 
-namespace Server
+namespace Server.Persistence
 {
   public sealed class DualSaveStrategy : StandardSaveStrategy
   {

Projects/Server/Persistence/DynamicSaveStrategy.cs

@@ -23,9 +23,8 @@ using System;
 using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Threading.Tasks;
-using Server.Guilds;
 
-namespace Server
+namespace Server.Persistence
 {
   public sealed class DynamicSaveStrategy : SaveStrategy
   {

Projects/Server/Persistence/FileOperations.cs

@@ -18,16 +18,9 @@
  *
  ***************************************************************************/
 
-
-using System;
 using System.IO;
-#if !MONO
-using System.Runtime.InteropServices;
-using Microsoft.Win32.SafeHandles;
 
-#endif
-
-namespace Server
+namespace Server.Persistence
 {
   public static class FileOperations
   {
@@ -38,12 +31,8 @@ namespace Server
 
     public static int Concurrency{ get; set; } = 1;
 
-    public static bool Unbuffered{ get; set; } = true;
-
     public static bool AreSynchronous => Concurrency < 1;
 
-    public static bool AreAsynchronous => Concurrency > 0;
-
     public static FileStream OpenSequentialStream(string path, FileMode mode, FileAccess access, FileShare share)
     {
       FileOptions options = FileOptions.SequentialScan;
@@ -104,6 +93,5 @@ namespace Server
       internal static extern SafeFileHandle CreateFile(string lpFileName, int dwDesiredAccess, FileShare dwShareMode,
         IntPtr securityAttrs, FileMode dwCreationDisposition, int dwFlagsAndAttributes, IntPtr hTemplateFile);
     }
-#endif
   }
 }

Projects/Server/Persistence/FileQueue.cs

@@ -23,7 +23,7 @@ using System.Buffers;
 using System.Collections.Generic;
 using System.Threading;
 
-namespace Server
+namespace Server.Persistence
 {
   public delegate void FileCommitCallback(FileQueue.Chunk chunk);
 
@@ -47,7 +47,7 @@ namespace Server
 
     public FileQueue(int concurrentWrites, FileCommitCallback callback)
     {
-      if (concurrentWrites < 1) throw new ArgumentOutOfRangeException("concurrentWrites");
+      if (concurrentWrites < 1) throw new ArgumentOutOfRangeException(nameof(concurrentWrites));
 
       if (bufferSize < 1)
         throw new ArgumentOutOfRangeException("bufferSize");
@@ -134,7 +134,7 @@ namespace Server
       {
         if (active[slot] != chunk) throw new ArgumentException();
 
-        ArrayPool<byte>.Shared.Return(chunk.Buffer);
+        ArrayPool<byte>.Shared.Return(chunk.Buffer, true);
 
         if (pending.Count > 0)
         {
@@ -157,18 +157,17 @@ namespace Server
 
     public void Enqueue(byte[] buffer, int offset, int size)
     {
-      if (buffer == null) throw new ArgumentNullException("buffer");
+      if (buffer == null) throw new ArgumentNullException(nameof(buffer));
 
-      if (offset < 0) throw new ArgumentOutOfRangeException("offset");
-      if (size < 0) throw new ArgumentOutOfRangeException("size");
+      if (offset < 0) throw new ArgumentOutOfRangeException(nameof(offset));
+      if (size < 0) throw new ArgumentOutOfRangeException(nameof(size));
       if (buffer.Length - offset < size) throw new ArgumentException();
 
       Position += size;
 
       while (size > 0)
       {
-        if (buffered.buffer == null)
-          buffered.buffer = ArrayPool<byte>.Shared.Rent(bufferSize);
+        buffered.buffer ??= ArrayPool<byte>.Shared.Rent(bufferSize);
 
         byte[] page = buffered.buffer; // buffer page
         int pageSpace = page.Length - buffered.length; // available bytes in page

Projects/Server/Persistence/ParallelSaveStrategy.cs

@@ -22,9 +22,8 @@ using System;
 using System.Collections;
 using System.Collections.Generic;
 using System.Threading;
-using Server.Guilds;
 
-namespace Server
+namespace Server.Persistence
 {
   public sealed class ParallelSaveStrategy : SaveStrategy
   {

Projects/Server/Persistence/Persistence.cs

@@ -5,7 +5,7 @@ using System.IO;
 
 #endregion
 
-namespace Server
+namespace Server.Persistence
 {
   public static class Persistence
   {

Projects/Server/Persistence/QueuedMemoryWriter.cs

@@ -21,7 +21,7 @@
 using System.Collections.Generic;
 using System.IO;
 
-namespace Server
+namespace Server.Persistence
 {
   public sealed class QueuedMemoryWriter : BinaryFileWriter
   {

Projects/Server/Persistence/SaveStrategy.cs

@@ -18,7 +18,7 @@
  *
  ***************************************************************************/
 
-namespace Server
+namespace Server.Persistence
 {
   public abstract class SaveStrategy
   {

Projects/Server/Persistence/SequentialFileWriter.cs

@@ -21,7 +21,7 @@
 using System;
 using System.IO;
 
-namespace Server
+namespace Server.Persistence
 {
   public sealed class SequentialFileWriter : Stream
   {

Projects/Server/Persistence/StandardSaveStrategy.cs

@@ -20,9 +20,8 @@
 
 using System;
 using System.Collections.Generic;
-using Server.Guilds;
 
-namespace Server
+namespace Server.Persistence
 {
   public class StandardSaveStrategy : SaveStrategy
   {
@@ -91,7 +90,7 @@ namespace Server
 
         idx.Write((int)(bin.Position - start));
 
-        m.FreeCache();
+        m.ClearProperties();
       }
 
       tdb.Write(World.m_MobileTypes.Count);
@@ -144,7 +143,7 @@ namespace Server
 
         idx.Write((int)(bin.Position - start));
 
-        item.FreeCache();
+        item.ClearProperties();
       }
 
       tdb.Write(World.m_ItemTypes.Count);