fix(core): Fixes several serialization issues (#355)

- [X] Fixes an issue where a buffer smaller than 8 bytes would not double with enough space in some cases.
- [X] Fixes an issue with dupe copying the savebuffer reference (ugh).
- [X] Streamlines the IGenericWriter API to use better generics.
- [X] Streamlines the IGenericReader API to use better generics.
- [X] Forces `tidying` of a List/HashSet to be done externally since Writers/Readers should not have side effects.
- [X] Fixes an issue where Tidying a list didn't TrimExcess, causing memory leaks.
- [X] Reverted the meaning of `World.Running` to specifically refer to any world state post world loading.
  - NOTE: Do not use this if you want to block on world saves. Instead use checks against `WorldState.Saving` states.
- [X] Fixes an issue with serializing negative DateTime deltas.
- [X] Fixes a potential issue with serializing non-UTC DateTime.

Bumps release version

Projects/UOContent/Engines/Quests/Dark Tides/Items/MaabusCoffin.cs

@@ -100,7 +100,7 @@ namespace Server.Engines.Quests.Necro
 
             var version = reader.ReadInt();
 
-            Maabus = reader.ReadMobile() as Maabus;
+            Maabus = reader.ReadEntity<Maabus>();
             SpawnLocation = reader.ReadPoint3D();
 
             Sleep();

Projects/UOContent/Engines/Quests/Dark Tides/Mobiles/SummonedPaladin.cs

@@ -150,7 +150,7 @@ namespace Server.Engines.Quests.Necro
 
             var version = reader.ReadInt();
 
-            m_Necromancer = reader.ReadMobile() as PlayerMobile;
+            m_Necromancer = reader.ReadEntity<PlayerMobile>();
             m_ToDelete = reader.ReadBool();
 
             if (m_ToDelete)

Projects/UOContent/Engines/Quests/Study of the Solen Hive/StudyOfSolenQuest.cs

@@ -41,7 +41,7 @@ namespace Server.Engines.Quests.Naturalist
         {
             var version = reader.ReadEncodedInt();
 
-            Naturalist = (Naturalist)reader.ReadMobile();
+            Naturalist = (Naturalist)reader.ReadEntity<Mobile>();
         }
 
         public override void ChildSerialize(IGenericWriter writer)

Projects/UOContent/Engines/Quests/The Summoning/Items/BellOfTheDead.cs

@@ -126,8 +126,8 @@ namespace Server.Engines.Quests.Doom
 
             var version = reader.ReadInt();
 
-            Chyloth = reader.ReadMobile() as Chyloth;
-            Dragon = reader.ReadMobile() as SkeletalDragon;
+            Chyloth = reader.ReadEntity<Chyloth>();
+            Dragon = reader.ReadEntity<SkeletalDragon>();
 
             Chyloth?.Delete();
         }

Projects/UOContent/Engines/Quests/The Summoning/Items/SummoningAltar.cs

@@ -54,7 +54,7 @@ namespace Server.Engines.Quests.Doom
 
             var version = reader.ReadInt();
 
-            m_Daemon = reader.ReadMobile() as BoneDemon;
+            m_Daemon = reader.ReadEntity<BoneDemon>();
 
             CheckDaemon();
         }

Projects/UOContent/Engines/Quests/The Summoning/Objectives.cs

@@ -173,8 +173,8 @@ namespace Server.Engines.Quests.Doom
         {
             var version = reader.ReadEncodedInt();
 
-            m_Daemon = reader.ReadMobile() as BoneDemon;
-            CorpseWithSkull = reader.ReadItem() as Corpse;
+            m_Daemon = reader.ReadEntity<BoneDemon>();
+            CorpseWithSkull = reader.ReadEntity<Corpse>();
         }
 
         public override void ChildSerialize(IGenericWriter writer)

Projects/UOContent/Engines/Quests/The Summoning/TheSummoningQuest.cs

@@ -105,7 +105,7 @@ namespace Server.Engines.Quests.Doom
         {
             var version = reader.ReadEncodedInt();
 
-            Victoria = reader.ReadMobile() as Victoria;
+            Victoria = reader.ReadEntity<Victoria>();
             WaitForSummon = reader.ReadBool();
         }
 

Projects/UOContent/Engines/Quests/Uzeraan Turmoil/Items/Cannon.cs

@@ -133,7 +133,7 @@ namespace Server.Engines.Quests.Haven
             var version = reader.ReadInt();
 
             CannonDirection = (CannonDirection)reader.ReadEncodedInt();
-            Canoneer = (MilitiaCanoneer)reader.ReadMobile();
+            Canoneer = (MilitiaCanoneer)reader.ReadEntity<Mobile>();
         }
     }
 

Projects/UOContent/Engines/Quests/Uzeraan Turmoil/Items/SchmendrickApprenticeCorpse.cs

@@ -205,7 +205,7 @@ namespace Server.Engines.Quests.Haven
 
             var version = reader.ReadInt();
 
-            m_Lantern = (Lantern)reader.ReadItem();
+            m_Lantern = (Lantern)reader.ReadEntity<Item>();
         }
     }
 }

Projects/UOContent/Engines/Quests/Uzeraan Turmoil/Objectives.cs

@@ -429,7 +429,7 @@ namespace Server.Engines.Quests.Haven
         {
             var version = reader.ReadEncodedInt();
 
-            CorpseWithBone = (Container)reader.ReadItem();
+            CorpseWithBone = (Container)reader.ReadEntity<Item>();
         }
 
         public override void ChildSerialize(IGenericWriter writer)

Projects/UOContent/Engines/Quests/Witch Apprentice/Objectives.cs

@@ -90,7 +90,7 @@ namespace Server.Engines.Quests.Hag
                     }
                 case 0:
                     {
-                        Corpse = (Corpse)reader.ReadItem();
+                        Corpse = (Corpse)reader.ReadEntity<Item>();
                         break;
                     }
             }