9a25054809
## Summary Many tests proved a specific change when it landed but don't need to run on every CI build forever. This removes **202 test methods and 9 files: 313 test cases, 2,247 → 1,934**. UOContent.Tests drops from about 14s to about 5s locally. Removed: - **Tautologies.** Asserting a constant, a constructor readback or a trivial getter, or testing BCL behavior. - **Exact duplicates** of a surviving test on the same code path. - **Obsolete regressions** whose failure can no longer be expressed. - **Game-content values** shard owners customize (era drop rates, loot and skill tables, single-creature tuning). Each customization would otherwise force a test fix. ## How it was decided 1. Every test was classified, with a reason, by a per-shard sweep over all 287 test files. 2. Each proposed deletion was then checked by a second, adversarial reviewer against the surviving tests and the production code. 3. Anything that was the only coverage of a separate code path was **kept**, even where it looked like a duplicate. Examples: the unsigned `SpanReader`/`SpanWriter` methods, the at-location versus bounds enumerators, null-map enumerables, the security filters, archive-journal state transitions. About 130 proposed deletions were rejected this way. Whole files removed: - `FishingTests`, apart from 3 tests: the map-edge scan, serpent cleanup, and SOS chest consumption. The SOS test now stops at the first chest instead of measuring a catch rate. The multi-million-cast rate simulations are gone. - `LordOaksTests` and `MeerEnragedTests` (single-creature tests). - `AutoArchiveHelperTests`, `JsonDiscoverableTypeAttributeTests`, `DecimalSerializationTests` and `EnumConversionTests` (tautologies, or tests of their own local helpers). - `NetworkStatsTests`. - `MigratedDataLoadTests` (a subset of `AllSpawnFilesLoadTests`). - `SpawnerFixtureCapture`: a capture tool, not a test, and its `version == 12` assert can no longer pass. The `.bin` fixtures it produced stay. ## Tests - Server.Tests: 811 pass. - UOContent.Tests: 1,123 pass. A follow-up PR, stacked on this one, fixes how the remaining tests behave: shared state, CI-vacuous tests, harness duplication.
98 lines
3.2 KiB
C#
98 lines
3.2 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using Server;
|
|
using Server.Mobiles;
|
|
using Xunit;
|
|
|
|
namespace UOContent.Tests.Mobiles.AI;
|
|
|
|
[Collection("Sequential UOContent Tests")]
|
|
public class SummonAcquireRulesTests : IDisposable
|
|
{
|
|
private readonly List<Mobile> _created = [];
|
|
private readonly Expansion _previous = Core.Expansion;
|
|
|
|
private PlayerMobile Player(Map map, int x, int intel)
|
|
{
|
|
var player = new PlayerMobile { Player = true, RawInt = intel };
|
|
player.MoveToWorld(new Point3D(x, 1600, map.GetAverageZ(x, 1600)), map);
|
|
_created.Add(player);
|
|
return player;
|
|
}
|
|
|
|
private BaseCreature Summon(BaseCreature summon, Mobile caster, int x)
|
|
{
|
|
_created.Add(summon);
|
|
summon.Summoned = true;
|
|
summon.Master = caster;
|
|
summon.MoveToWorld(new Point3D(x, 1600, caster.Map.GetAverageZ(x, 1600)), caster.Map);
|
|
summon.AIObject.AITimer.Stop();
|
|
return summon;
|
|
}
|
|
|
|
private static bool Acquire(BaseCreature creature)
|
|
{
|
|
creature.NextReacquireTime = Core.TickCount - 1;
|
|
return creature.AIObject.AcquireFocusMob(creature.RangePerception, creature.FightMode, false, false, true);
|
|
}
|
|
|
|
[SkippableFact]
|
|
public void PreAosFeluccaVortexPrefersAnyoneOverItsCaster()
|
|
{
|
|
Skip.If(!Server.Tests.TestServerInitializer.TileDataLoaded, "Requires UO client map data.");
|
|
Core.Expansion = Expansion.UOR;
|
|
|
|
// The caster outranks the bystander on the vortex's int-over-distance ranking.
|
|
var caster = Player(Map.Felucca, 1500, 100);
|
|
var bystander = Player(Map.Felucca, 1496, 10);
|
|
var vortex = Summon(new EnergyVortex(), caster, 1499);
|
|
|
|
Assert.True(Acquire(vortex));
|
|
Assert.Same(bystander, vortex.FocusMob);
|
|
}
|
|
|
|
[SkippableTheory]
|
|
[InlineData(Expansion.UOR, 1)] // Trammel
|
|
[InlineData(Expansion.AOS, 0)] // Felucca
|
|
public void VortexSparesItsCasterOutsidePreAosFelucca(Expansion expansion, int mapIndex)
|
|
{
|
|
Skip.If(!Server.Tests.TestServerInitializer.TileDataLoaded, "Requires UO client map data.");
|
|
Core.Expansion = expansion;
|
|
|
|
var caster = Player(Map.Maps[mapIndex], 1500, 100);
|
|
var vortex = Summon(new EnergyVortex(), caster, 1499);
|
|
|
|
Assert.False(Acquire(vortex));
|
|
Assert.Null(vortex.FocusMob);
|
|
}
|
|
|
|
[SkippableFact]
|
|
public void MasterlessSummonDoesNotBreakAcquisition()
|
|
{
|
|
Skip.If(!Server.Tests.TestServerInitializer.TileDataLoaded, "Requires UO client map data.");
|
|
Core.Expansion = Expansion.AOS;
|
|
|
|
var player = Player(Map.Felucca, 1500, 100);
|
|
var hunter = new PetTestStub();
|
|
_created.Add(hunter);
|
|
hunter.MoveToWorld(new Point3D(1499, 1600, player.Z), player.Map);
|
|
hunter.AIObject.AITimer.Stop();
|
|
|
|
var masterless = new PetTestStub { Summoned = true };
|
|
_created.Add(masterless);
|
|
masterless.MoveToWorld(new Point3D(1498, 1600, player.Z), player.Map);
|
|
masterless.AIObject.AITimer.Stop();
|
|
|
|
Assert.True(Acquire(hunter));
|
|
}
|
|
|
|
public void Dispose()
|
|
{
|
|
Core.Expansion = _previous;
|
|
|
|
foreach (var mobile in _created)
|
|
{
|
|
mobile.Delete();
|
|
}
|
|
}
|
|
}
|