ModernUO/Projects/UOContent.Tests/Tests/Mobiles/AI
Kamron Batman 9a25054809
test: remove trivial, duplicate and content-value tests (#2721)
## Summary
Many tests proved a specific change when it landed but don't need to run on every CI build forever. This removes **202 test methods and 9 files: 313 test cases, 2,247 → 1,934**. UOContent.Tests drops from about 14s to about 5s locally.

Removed:
- **Tautologies.** Asserting a constant, a constructor readback or a trivial getter, or testing BCL behavior.
- **Exact duplicates** of a surviving test on the same code path.
- **Obsolete regressions** whose failure can no longer be expressed.
- **Game-content values** shard owners customize (era drop rates, loot and skill tables, single-creature tuning). Each customization would otherwise force a test fix.

## How it was decided
1. Every test was classified, with a reason, by a per-shard sweep over all 287 test files.
2. Each proposed deletion was then checked by a second, adversarial reviewer against the surviving tests and the production code.
3. Anything that was the only coverage of a separate code path was **kept**, even where it looked like a duplicate. Examples: the unsigned `SpanReader`/`SpanWriter` methods, the at-location versus bounds enumerators, null-map enumerables, the security filters, archive-journal state transitions. About 130 proposed deletions were rejected this way.

Whole files removed:
- `FishingTests`, apart from 3 tests: the map-edge scan, serpent cleanup, and SOS chest consumption. The SOS test now stops at the first chest instead of measuring a catch rate. The multi-million-cast rate simulations are gone.
- `LordOaksTests` and `MeerEnragedTests` (single-creature tests).
- `AutoArchiveHelperTests`, `JsonDiscoverableTypeAttributeTests`, `DecimalSerializationTests` and `EnumConversionTests` (tautologies, or tests of their own local helpers).
- `NetworkStatsTests`.
- `MigratedDataLoadTests` (a subset of `AllSpawnFilesLoadTests`).
- `SpawnerFixtureCapture`: a capture tool, not a test, and its `version == 12` assert can no longer pass. The `.bin` fixtures it produced stay.

## Tests
- Server.Tests: 811 pass.
- UOContent.Tests: 1,123 pass.

A follow-up PR, stacked on this one, fixes how the remaining tests behave: shared state, CI-vacuous tests, harness duplication.
2026-10-18 20:08:19 -07:00
..
AcquisitionTests.cs feat: event-driven target acquisition with a reaction-time gradient (#2601) 2026-09-01 20:42:15 -07:00
AIDeactivationTests.cs fix: handle null maps when deactivating creature AI (#2629) 2026-09-11 17:26:47 -07:00
ApproachOutcomeTests.cs fix(ai): FamiliarAI owns familiar movement and combat; herding reaches its tile; ForcedAI read once (#2644) 2026-09-14 23:14:30 -07:00
ApproachTargetTests.cs fix(ai): FamiliarAI owns familiar movement and combat; herding reaches its tile; ForcedAI read once (#2644) 2026-09-14 23:14:30 -07:00
DebugMessageTimingTests.cs fix(ai): make debug-message cooldown comparisons wraparound-safe (#2659) 2026-09-19 09:59:00 -07:00
DetectHiddenTimerTests.cs fix(ai): guard zero-int detection cooldown and duplicate pet friends (#2667) 2026-09-23 10:42:38 -07:00
FamiliarAITests.cs test: remove trivial, duplicate and content-value tests (#2721) 2026-10-18 20:08:19 -07:00
ForcedAITests.cs fix(ai): FamiliarAI owns familiar movement and combat; herding reaches its tile; ForcedAI read once (#2644) 2026-09-14 23:14:30 -07:00
GuardFollowTests.cs test: remove trivial, duplicate and content-value tests (#2721) 2026-10-18 20:08:19 -07:00
GuardFriendlyFireTests.cs refactor: master views over BaseCreature's one master reference (#2674) 2026-09-24 22:45:24 -07:00
GuardOrderTests.cs fix: pet obedience pacing, stale AI wake rescheduling, and Guard order persistence through combat (#2594) 2026-08-30 16:39:29 -07:00
HerdingTests.cs fix(ai): FamiliarAI owns familiar movement and combat; herding reaches its tile; ForcedAI read once (#2644) 2026-09-14 23:14:30 -07:00
MoveSpeedTests.cs refactor: Changes BaseCreature to the SerializationGenerator (delta save requirement) (#2611) 2026-09-06 14:11:51 -07:00
PetFriendMembershipTests.cs fix(ai): guard zero-int detection cooldown and duplicate pet friends (#2667) 2026-09-23 10:42:38 -07:00
PetOrderTests.cs test: remove trivial, duplicate and content-value tests (#2721) 2026-10-18 20:08:19 -07:00
PetPacingTests.cs test: remove trivial, duplicate and content-value tests (#2721) 2026-10-18 20:08:19 -07:00
PetRetaliationTests.cs refactor: master views over BaseCreature's one master reference (#2674) 2026-09-24 22:45:24 -07:00
PetTestStub.cs fix: pets freeze, forget their orders, obey the wrong players, and fight when told not to (#2614) 2026-09-10 19:28:13 -07:00
RunFlagTests.cs feat: derive the Running bit from the step pace and fix step-pacing bursts (#2599) 2026-08-30 16:48:52 -07:00
SummonAcquireRulesTests.cs test: remove trivial, duplicate and content-value tests (#2721) 2026-10-18 20:08:19 -07:00