ModernUO/Projects/UOContent/Mobiles/Vendors/NPC
Kamron Batman 410a964789
fix: NPC outfits no longer stack two items on one layer (#2715)
Companion to #2712, which covers HireRanger's refused `EquipItem`. A sweep that built every constructible Mobile 2,000 times under each expansion found these other outfits that put two items on one layer. They don't leak, because `AddItem` skips `CheckEquip`, but the NPC wears both items and the client draws only one.

| NPC | Conflict |
|---|---|
| Miner, Ranger, Thief | Own shirt/pants/ThighBoots added on top of the random `BaseVendor.InitOutfit` (shoes doubled on every spawn) |
| MasterTheophilus | Shoes + Robe added over `EvilMageLord`'s Sandals + Robe |
| Merchant | Shirt + FancyShirt, or PlainDress + FancyDress |
| IronWorker | Bandana/JesterHat + Bascinet |
| MeerCaptain | One-handed sword + Crossbow |
| BakeKitsune | `BodyMod` isn't saved, so after a restart `RemoveDisguise` bailed and the next `Disguise()` stacked a second robe and pair of shoes |

## Changes
- `BaseCreature.ReplaceEquipment(item)` equips an item in place of whatever an inherited outfit put on its layer, and deletes the item if it still can't be equipped.
- Miner, Ranger, Thief, MasterTheophilus: their own pieces replace the inherited ones.
- Merchant and IronWorker: dropped the duplicate roll. Each kept the item the client was already drawing, which is the last one sent: the fancy set and the Bascinet.
- MeerCaptain: the sword goes into its pack as loot. **Behavior change:** `Mobile.Weapon` checks the one-handed layer first, so it was fighting with the sword despite its archer AI, its Archery skill and the bolts in its pack. It now uses the crossbow.
- BakeKitsune: `RemoveDisguise` strips the disguise without checking `IsBodyMod`.

## Testing
- I re-ran the sweep (local diagnostic, not committed; needs client tiledata) at 500 rolls × 12 expansions. Only HireRanger (#2712) and LordOaks (separate fix coming) remain.
- UOContent.Tests: 1218 passed, 2 skipped.
2026-10-17 16:17:11 -07:00
..
Guildmasters feat: Pre-Publish 14 Crafting (supersedes #2181, #2381) (#2476) 2026-06-07 20:27:22 -07:00
Alchemist.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
AnimalTrainer.cs refactor: one master reference behind ControlMaster and SummonMaster (#2670) 2026-09-24 21:37:28 -07:00
Architect.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Armorer.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Baker.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Bard.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Barkeeper.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Beekeeper.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Blacksmith.cs chore: Fixes variable types for possible performance issues (#2172) 2025-05-01 21:54:41 -07:00
Bowyer.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Butcher.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Carpenter.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Cobbler.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Cook.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
CustomHairstylist.cs fix: Refactors Custom Hairstylist (#2188) 2025-05-17 03:30:07 -07:00
Farmer.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Fisherman.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Furtrader.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Glassblower.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
GolemCrafter.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
GypsyAnimalTrainer.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
GypsyBanker.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
GypsyMaiden.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
HairStylist.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Herbalist.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
HolyMage.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
InnKeeper.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
IronWorker.cs fix: NPC outfits no longer stack two items on one layer (#2715) 2026-10-17 16:17:11 -07:00
Jeweler.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
KeeperOfChivalry.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
LeatherWorker.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Mage.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Mapmaker.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Miller.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Miner.cs fix: NPC outfits no longer stack two items on one layer (#2715) 2026-10-17 16:17:11 -07:00
Monk.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Provisioner.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Rancher.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Ranger.cs fix: NPC outfits no longer stack two items on one layer (#2715) 2026-10-17 16:17:11 -07:00
RealEstateBroker.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Scribe.cs fix: sell Bushido and Ninjitsu books through Tokuno scribes (#2622) 2026-09-09 23:07:32 -07:00
Shipwright.cs fix: Fixes missing codegen for ShipWright (#1316) 2022-12-30 10:48:42 -08:00
StoneCrafter.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Tailor.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Tanner.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
TavernKeeper.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Thief.cs fix: NPC outfits no longer stack two items on one layer (#2715) 2026-10-17 16:17:11 -07:00
Tinker.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Vagabond.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
VarietyDealer.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Veterinarian.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Waiter.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Weaponsmith.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00
Weaver.cs fix: Changes on Vendor>NPC to use code generation (#1308) 2022-12-22 12:40:26 -08:00