Replaces the per-entity round-robin ConcurrentQueue handoff between the game loop and the serialization workers with pooled 4096-entity chunks published to a single shared queue. The producer's per-entity cost drops from a synchronized enqueue to a plain array store, and workers pulling whole chunks load-balance dynamically: a worker busy with a thick entity simply takes fewer chunks. Scheduling changes so indivisible multi-megabyte payloads no longer extend the freeze tail: - Persistence.SerializeAll pushes systems largest-first (LPT), using the previous save's SerializedLength (or the loaded file size on first save). - Persistence self-payloads and entities whose previous size exceeds 1MB are published as dedicated single-entity chunks so they spread across workers instead of riding inside one shared chunk. - Entity SerializedLength is stamped from the index at load so estimates exist on the first save after boot. Worker heaps are pre-sized from the loaded save's .bin sizes (25% headroom) so the first save doesn't pay copy-on-grow inside the freeze, and the drain loop uses SpinWait backoff (never Sleep(1)) instead of hammering the queue head while the producer works. Snapshot writing uses a 1MB FileStream buffer, and per-worker entity/byte counts are logged at Debug for balance diagnostics. Measured on a 24-core machine with a synthetic 10M-entity, 1.7GB world (64/64/32MB system payloads, 24x 2MB thick entities) through the real pipeline classes: freeze window 740ms -> 122-160ms steady state (~5-6x), first save 490ms -> 330ms, steady-state allocations converge to zero, and worker byte loads converge (previous max/min spread ~2x -> ~1.15x for the small-entity stream). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
208 lines
6.2 KiB
C#
208 lines
6.2 KiB
C#
/*************************************************************************
|
|
* ModernUO *
|
|
* Copyright 2019-2026 - ModernUO Development Team *
|
|
* Email: hi@modernuo.com *
|
|
* File: Persistence.cs *
|
|
* *
|
|
* This program is free software: you can redistribute it and/or modify *
|
|
* it under the terms of the GNU General Public License as published by *
|
|
* the Free Software Foundation, either version 3 of the License, or *
|
|
* (at your option) any later version. *
|
|
* *
|
|
* You should have received a copy of the GNU General Public License *
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>. *
|
|
*************************************************************************/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.IO;
|
|
using System.IO.MemoryMappedFiles;
|
|
|
|
namespace Server;
|
|
|
|
public abstract class Persistence
|
|
{
|
|
private static readonly SortedSet<Persistence> _registry = new(new PersistenceComparer());
|
|
|
|
public int Priority { get; }
|
|
|
|
public Persistence(int priority = 100)
|
|
{
|
|
Priority = priority;
|
|
_registry.Add(this);
|
|
}
|
|
|
|
public bool Register() => _registry.Add(this);
|
|
|
|
public void Unregister() => _registry.Remove(this);
|
|
|
|
public static void Load(string path)
|
|
{
|
|
var typesDb = LoadTypes(path);
|
|
|
|
foreach (var entry in _registry)
|
|
{
|
|
(entry as IGenericEntityPersistence)?.DeserializeIndexes(path, typesDb);
|
|
}
|
|
|
|
// This should probably not be parallel since Mobiles must be loaded before Items
|
|
foreach (var entry in _registry)
|
|
{
|
|
entry.Deserialize(path, typesDb);
|
|
}
|
|
}
|
|
|
|
private static unsafe Dictionary<ulong, string> LoadTypes(string path)
|
|
{
|
|
var db = new Dictionary<ulong, string>();
|
|
|
|
var typesPath = Path.Combine(path, "SerializedTypes.db");
|
|
if (!File.Exists(typesPath))
|
|
{
|
|
return db;
|
|
}
|
|
|
|
using var mmf = MemoryMappedFile.CreateFromFile(typesPath, FileMode.Open);
|
|
using var accessor = mmf.CreateViewStream();
|
|
|
|
byte* ptr = null;
|
|
accessor.SafeMemoryMappedViewHandle.AcquirePointer(ref ptr);
|
|
var dataReader = new UnmanagedDataReader(ptr, accessor.Length);
|
|
|
|
var version = dataReader.ReadInt();
|
|
var count = dataReader.ReadInt();
|
|
|
|
for (var i = 0; i < count; ++i)
|
|
{
|
|
var hash = dataReader.ReadULong();
|
|
var typeName = dataReader.ReadStringRaw();
|
|
db[hash] = typeName;
|
|
}
|
|
|
|
accessor.SafeMemoryMappedViewHandle.ReleasePointer();
|
|
return db;
|
|
}
|
|
|
|
// Note: This is strictly on a background thread
|
|
internal static void WriteSnapshotAll(string path, HashSet<Type> typeSet)
|
|
{
|
|
foreach (var p in _registry)
|
|
{
|
|
p.WriteSnapshot(path, typeSet);
|
|
}
|
|
|
|
WriteSerializedTypesSnapshot(path, typeSet);
|
|
}
|
|
|
|
public static void WriteSerializedTypesSnapshot(string path, HashSet<Type> types)
|
|
{
|
|
var typesPath = Path.Combine(path, "SerializedTypes.db");
|
|
using var fs = new FileStream(typesPath, FileMode.Create);
|
|
using var writer = new MemoryMapFileWriter(fs, 1024 * 1024 * 4);
|
|
|
|
writer.Write(0); // version
|
|
writer.Write(types.Count);
|
|
|
|
foreach (var type in types)
|
|
{
|
|
var fullName = type.FullName;
|
|
writer.Write(HashUtility.ComputeHash64(fullName));
|
|
writer.WriteStringRaw(fullName);
|
|
}
|
|
}
|
|
|
|
internal static void SerializeAll()
|
|
{
|
|
// Largest known payloads first (LPT scheduling). An indivisible multi-megabyte system
|
|
// serialized last extends the freeze by its entire duration; serialized first it overlaps
|
|
// the entity stream. Sizes come from the previous save, or the loaded files on first save.
|
|
var ordered = new Persistence[_registry.Count];
|
|
_registry.CopyTo(ordered);
|
|
Array.Sort(ordered, static (a, b) => GetEstimatedSize(b).CompareTo(GetEstimatedSize(a)));
|
|
|
|
foreach (var p in ordered)
|
|
{
|
|
p.Serialize();
|
|
}
|
|
}
|
|
|
|
private static long GetEstimatedSize(Persistence p) => (p as GenericPersistence)?.EstimatedSize ?? 0;
|
|
|
|
internal static void PostWorldSaveAll()
|
|
{
|
|
foreach (var p in _registry)
|
|
{
|
|
p.PostWorldSave();
|
|
}
|
|
}
|
|
|
|
internal static void PostDeserializeAll()
|
|
{
|
|
foreach (var p in _registry)
|
|
{
|
|
p.PostDeserialize();
|
|
}
|
|
}
|
|
|
|
// Note: This should only be run on a background thread
|
|
public abstract void WriteSnapshot(string savePath, HashSet<Type> typeSet);
|
|
|
|
public abstract void Serialize();
|
|
|
|
public abstract void Deserialize(string savePath, Dictionary<ulong, string> typesDb);
|
|
|
|
public virtual void PostWorldSave()
|
|
{
|
|
}
|
|
|
|
public virtual void PostDeserialize()
|
|
{
|
|
}
|
|
|
|
internal class PersistenceComparer : IComparer<Persistence>
|
|
{
|
|
public int Compare(Persistence x, Persistence y)
|
|
{
|
|
if (x == y)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
if (x == null)
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
if (y == null)
|
|
{
|
|
return -1;
|
|
}
|
|
|
|
// First sort by priority
|
|
var cmp = x.Priority.CompareTo(y.Priority);
|
|
|
|
// Then alphabetically. We won't allow the same entry (by name) twice in the SortedSet
|
|
return cmp != 0 ? cmp : x.GetHashCode().CompareTo(y.GetHashCode());
|
|
}
|
|
}
|
|
|
|
public static void TraceException(Exception ex)
|
|
{
|
|
try
|
|
{
|
|
using var op = new StreamWriter("save-errors.log", true);
|
|
op.WriteLine("# {0}", Core.Now);
|
|
|
|
op.WriteLine(ex);
|
|
|
|
op.WriteLine();
|
|
op.WriteLine();
|
|
}
|
|
catch
|
|
{
|
|
// ignored
|
|
}
|
|
|
|
Console.WriteLine(ex);
|
|
}
|
|
}
|