ModernUO/Projects/UOContent/Items
Kamron Batman f77dd91811
fix: Overhauls virtue system (#1376)
## MAJOR CHANGE (API BREAKING)

Moved the virtues to it's own system _VirtueSystem_. This should make it easier to extend or remove the virtue system. Virtues will be saved to a new folder called _Virtues_.

### Motivation

The motivation was also two-fold, performance/stability, and to fix bugs.

First, virtues is the second system (first is murders), that has a pre-world-save check on _every mobile in the game_ to atrophy virtue stats. This is taxing since it freexes the world and makes world saves take longer. Every mobile had Gain/Loss dates for each virtue, whether they needed them or not. Most players don't even use the virtue system, so this will increase performance considerably.

Second, when I tried to optimize/refactor the code, I found several bugs that needed to be fixed.

### Major API Changes

- [X] The properties on players related to virtues are gone. Use `pm.GetVirtues()?.<PropertyName>` instead.
- [X] Virtues were removed from non-player Mobiles.
- [X] `pm.JusticeProtectors` was removed. Use `JusticeVirtue.GetProtector()` or `JusticeVirtue.GetProtected()` instead.

### Screenshots

<img width="221" alt="Props-1" src="https://github.com/modernuo/ModernUO/assets/3953314/5c09cb83-b8d5-44a2-b899-a7ed7cd736ac">
<img width="220" alt="props-2" src="https://github.com/modernuo/ModernUO/assets/3953314/aeade4d3-8df0-47bd-955a-a864d0946cf7">
2023-07-19 21:43:47 -07:00
..
Addons fix: Updates messages with clilocs (#1381) 2023-03-26 00:54:09 -07:00
Aquarium feat: Adds SerializedCommandProperty (#1249) 2022-11-14 18:24:33 -08:00
Armor fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
Body Parts feat: Adds SerializedCommandProperty (#1249) 2022-11-14 18:24:33 -08:00
Books fix: Cleans up murder system (#1428) 2023-07-16 00:04:30 -07:00
Bulletin Boards fix: Fixes infinite loop in bulletin board cleanup (#1394) 2023-04-18 19:27:40 -07:00
Champion Artifacts fix: Fixes random bias & Adds back champion arties for UOML (#1235) 2022-11-09 16:33:27 -08:00
Clothing fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
Construction fix: Fixes doors as decorations & optimizes them (#1392) 2023-04-18 19:28:54 -07:00
Containers fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
Decoration Artifacts fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
Deeds fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
Facial Formats UO Content (#201) 2020-08-27 18:30:38 -07:00
Farming fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
Food fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
Games fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
Gems fix: Codegens gems (#1059) 2022-06-13 17:38:46 -07:00
Guilds feat: Adds SerializedCommandProperty (#1249) 2022-11-14 18:24:33 -08:00
Jewels feat: Adds IAosItem for items with AosAttributes (#1268) 2022-11-23 10:49:30 -08:00
Lights feat: Adds SerializedCommandProperty (#1249) 2022-11-14 18:24:33 -08:00
Maps fix: Updates messages with clilocs (#1381) 2023-03-26 00:54:09 -07:00
Minor Artifacts fix: Fixes serious stacking issue (#1225) 2022-11-02 22:18:44 -07:00
Misc fix: Fixes stabled, abilities targeting self, and unsummon memory leak (#1418) 2023-07-03 09:45:22 -07:00
New Haven Quest Rewards fix: Codegen new haven quest rewards (#1269) 2022-11-23 13:00:28 -08:00
PlantsFlowers/Potted fix: Codegens potted plants (#1270) 2022-11-23 13:04:30 -08:00
Quivers fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
Resources fix: Fixes scales, heritage items, and codegens holiday items (#1365) 2023-03-07 22:38:35 -08:00
Shields fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
Skill Items fix: Fixes spellbook not showing SpellCount when added non-empty. (#1424) 2023-07-04 16:14:04 -07:00
Special fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
Suits chore: Cleans up pattern checks. (#892) 2021-12-24 15:53:59 -08:00
Talismans fix: Updates messages with clilocs (#1381) 2023-03-26 00:54:09 -07:00
Traps fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
TreasureChests fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
Wands feat: Adds SerializedCommandProperty (#1249) 2022-11-14 18:24:33 -08:00
Weapons fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00