## Breaking Changes (New API)
ObjectPropertyList supports the following API:
```cs
list.Add(500000);
list.Add(500001, stringArgument);
list.Add("Some text");
list.Add($"Some text with {argument}");
list.Add(500002, $"{arg1}\t{arg2}");
```
## Notes
1. All API uses that require a formatter like this:
```cs
list.Add(500002, "{0}\t{1}", arg1, arg2);
```
Should be changed to use string interpolation, for example:
```cs
list.Add(500002, $"{arg1}\t{arg2}");
```
2. The following paradigm should no longer be used:
```cs
list.Add(1061170, prop.ToString()); // strength requirement ~1_val~
```
The new string interpolation API will avoid having to convert the argument to a string before writing it to the packet. Instead use the following:
```cs
list.Add(1061170, $"{prop}"); // strength requirement ~1_val~
```
### Benchmarks
```cs
| Method | Mean | Error | StdDev | Gen 0 | Allocated |
|------------------------------- |---------:|--------:|--------:|-------:|----------:|
| BenchmarkOldOPL | 241.0 ns | 0.56 ns | 0.47 ns | 0.0105 | 88 B |
| BenchmarkStringInterpolatedOPL | 199.9 ns | 2.44 ns | 2.39 ns | - | - |
```
### Changes
- [X] Removes crash in STArray.Return when array is null.
- [X] Fixes NPE in OPL when entity is null. Serial in packet will be 0 when entity is null.
- [X] Fixes NPE in AosAttributes when Parent is null.
- [X] Changes OPL to use string interpolation.
- [X] Introduces `IPropertyList` to allow extending PropertyList for other uses.
232 lines
7.6 KiB
C#
232 lines
7.6 KiB
C#
using System;
|
|
using Server.Items;
|
|
using Server.Mobiles;
|
|
|
|
namespace Server.Engines.BulkOrders
|
|
{
|
|
public abstract class SmallBOD : BaseBOD
|
|
{
|
|
private int m_AmountCur;
|
|
private int m_Number;
|
|
|
|
public SmallBOD(
|
|
int hue, int amountCur, int amountMax, Type type, int number, int graphic, bool requireExeptional,
|
|
BulkMaterialType material
|
|
) : base(hue, amountMax, requireExeptional, material)
|
|
{
|
|
Type = type;
|
|
Graphic = graphic;
|
|
m_AmountCur = amountCur;
|
|
m_Number = number;
|
|
}
|
|
|
|
public SmallBOD()
|
|
{
|
|
}
|
|
|
|
public SmallBOD(Serial serial) : base(serial)
|
|
{
|
|
}
|
|
|
|
[CommandProperty(AccessLevel.GameMaster)]
|
|
public int AmountCur
|
|
{
|
|
get => m_AmountCur;
|
|
set
|
|
{
|
|
m_AmountCur = value;
|
|
InvalidateProperties();
|
|
}
|
|
}
|
|
|
|
[CommandProperty(AccessLevel.GameMaster)]
|
|
public Type Type { get; set; }
|
|
|
|
[CommandProperty(AccessLevel.GameMaster)]
|
|
public int Number
|
|
{
|
|
get => m_Number;
|
|
set
|
|
{
|
|
m_Number = value;
|
|
InvalidateProperties();
|
|
}
|
|
}
|
|
|
|
[CommandProperty(AccessLevel.GameMaster)]
|
|
public int Graphic { get; set; }
|
|
|
|
[CommandProperty(AccessLevel.GameMaster)]
|
|
public override bool Complete => m_AmountCur == AmountMax;
|
|
|
|
public override int LabelNumber => 1045151; // a bulk order deed
|
|
|
|
public override void GetProperties(IPropertyList list)
|
|
{
|
|
base.GetProperties(list);
|
|
|
|
list.Add(1060654); // small bulk order
|
|
|
|
if (RequireExceptional)
|
|
{
|
|
list.Add(1045141); // All items must be exceptional.
|
|
}
|
|
|
|
if (Material != BulkMaterialType.None)
|
|
{
|
|
list.Add(SmallBODGump.GetMaterialNumberFor(Material)); // All items must be made with x material.
|
|
}
|
|
|
|
list.Add(1060656, $"{AmountMax}"); // amount to make: ~1_val~
|
|
list.Add(1060658, $"#{m_Number}\t{m_AmountCur}"); // ~1_val~: ~2_val~
|
|
}
|
|
|
|
public override void OnDoubleClick(Mobile from)
|
|
{
|
|
if (IsChildOf(from.Backpack) || InSecureTrade || RootParent is PlayerVendor)
|
|
{
|
|
from.SendGump(new SmallBODGump(from, this));
|
|
}
|
|
else
|
|
{
|
|
from.SendLocalizedMessage(1045156); // You must have the deed in your backpack to use it.
|
|
}
|
|
}
|
|
|
|
public override void OnDoubleClickNotAccessible(Mobile from)
|
|
{
|
|
OnDoubleClick(from);
|
|
}
|
|
|
|
public override void OnDoubleClickSecureTrade(Mobile from)
|
|
{
|
|
OnDoubleClick(from);
|
|
}
|
|
|
|
public static BulkMaterialType GetMaterial(CraftResource resource)
|
|
{
|
|
return resource switch
|
|
{
|
|
CraftResource.DullCopper => BulkMaterialType.DullCopper,
|
|
CraftResource.ShadowIron => BulkMaterialType.ShadowIron,
|
|
CraftResource.Copper => BulkMaterialType.Copper,
|
|
CraftResource.Bronze => BulkMaterialType.Bronze,
|
|
CraftResource.Gold => BulkMaterialType.Gold,
|
|
CraftResource.Agapite => BulkMaterialType.Agapite,
|
|
CraftResource.Verite => BulkMaterialType.Verite,
|
|
CraftResource.Valorite => BulkMaterialType.Valorite,
|
|
CraftResource.SpinedLeather => BulkMaterialType.Spined,
|
|
CraftResource.HornedLeather => BulkMaterialType.Horned,
|
|
CraftResource.BarbedLeather => BulkMaterialType.Barbed,
|
|
_ => BulkMaterialType.None
|
|
};
|
|
}
|
|
|
|
public override void EndCombine(Mobile from, Item item)
|
|
{
|
|
var objectType = item.GetType();
|
|
|
|
if (m_AmountCur >= AmountMax)
|
|
{
|
|
// The maximum amount of requested items have already been combined to this deed.
|
|
from.SendLocalizedMessage(1045166);
|
|
}
|
|
else if (Type == null || objectType != Type && !objectType.IsSubclassOf(Type) ||
|
|
item is not BaseWeapon && item is not BaseArmor && item is not BaseClothing)
|
|
{
|
|
from.SendLocalizedMessage(1045169); // The item is not in the request.
|
|
}
|
|
else
|
|
{
|
|
var armor = item as BaseArmor;
|
|
var clothing = item as BaseClothing;
|
|
|
|
var material = GetMaterial(armor?.Resource ?? clothing?.Resource ?? CraftResource.None);
|
|
|
|
if (Material >= BulkMaterialType.DullCopper && Material <= BulkMaterialType.Valorite &&
|
|
material != Material)
|
|
{
|
|
from.SendLocalizedMessage(1045168); // The item is not made from the requested ore.
|
|
}
|
|
else if (Material >= BulkMaterialType.Spined && Material <= BulkMaterialType.Barbed &&
|
|
material != Material)
|
|
{
|
|
from.SendLocalizedMessage(1049352); // The item is not made from the requested leather type.
|
|
}
|
|
else
|
|
{
|
|
bool isExceptional;
|
|
|
|
if (item is BaseWeapon weapon)
|
|
{
|
|
isExceptional = weapon.Quality == WeaponQuality.Exceptional;
|
|
}
|
|
else if (armor != null)
|
|
{
|
|
isExceptional = armor.Quality == ArmorQuality.Exceptional;
|
|
}
|
|
else
|
|
{
|
|
isExceptional = clothing.Quality == ClothingQuality.Exceptional;
|
|
}
|
|
|
|
if (RequireExceptional && !isExceptional)
|
|
{
|
|
from.SendLocalizedMessage(1045167); // The item must be exceptional.
|
|
}
|
|
else
|
|
{
|
|
item.Delete();
|
|
++AmountCur;
|
|
|
|
from.SendLocalizedMessage(1045170); // The item has been combined with the deed.
|
|
from.SendGump(new SmallBODGump(from, this));
|
|
|
|
if (m_AmountCur < AmountMax)
|
|
{
|
|
BeginCombine(from);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
public override void Serialize(IGenericWriter writer)
|
|
{
|
|
base.Serialize(writer);
|
|
|
|
writer.Write(0); // version
|
|
|
|
writer.Write(m_AmountCur);
|
|
writer.Write(Type?.FullName);
|
|
writer.Write(m_Number);
|
|
writer.Write(Graphic);
|
|
}
|
|
|
|
public override void Deserialize(IGenericReader reader)
|
|
{
|
|
base.Deserialize(reader);
|
|
|
|
var version = reader.ReadInt();
|
|
|
|
switch (version)
|
|
{
|
|
case 0:
|
|
{
|
|
m_AmountCur = reader.ReadInt();
|
|
|
|
var type = reader.ReadString();
|
|
|
|
if (type != null)
|
|
{
|
|
Type = AssemblyHandler.FindTypeByFullName(type);
|
|
}
|
|
|
|
m_Number = reader.ReadInt();
|
|
Graphic = reader.ReadInt();
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|