warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
ModernUO/Projects/UOContent/Engines/ML Quests/Items
History
Kamron Batman ecbee17690
fix: Optimizes OPL using string interpolation (#1041) 
## Breaking Changes (New API)
ObjectPropertyList supports the following API:
```cs
list.Add(500000);
list.Add(500001, stringArgument);
list.Add("Some text");
list.Add($"Some text with {argument}");
list.Add(500002, $"{arg1}\t{arg2}");
```

## Notes
1. All API uses that require a formatter like this:
    ```cs
    list.Add(500002, "{0}\t{1}", arg1, arg2);
    ```
    Should be changed to use string interpolation, for example:
    ```cs
    list.Add(500002, $"{arg1}\t{arg2}");
    ```
2. The following paradigm should no longer be used:
    ```cs
    list.Add(1061170, prop.ToString()); // strength requirement ~1_val~
    ```
    The new string interpolation API will avoid having to convert the argument to a string before writing it to the packet. Instead use the following:
    ```cs
    list.Add(1061170, $"{prop}"); // strength requirement ~1_val~
    ```

### Benchmarks
```cs
|                         Method |     Mean |   Error |  StdDev |  Gen 0 | Allocated |
|------------------------------- |---------:|--------:|--------:|-------:|----------:|
|                BenchmarkOldOPL | 241.0 ns | 0.56 ns | 0.47 ns | 0.0105 |      88 B |
| BenchmarkStringInterpolatedOPL | 199.9 ns | 2.44 ns | 2.39 ns |      - |         - |
```

### Changes
- [X] Removes crash in STArray.Return when array is null.
- [X] Fixes NPE in OPL when entity is null. Serial in packet will be 0 when entity is null.
- [X] Fixes NPE in AosAttributes when Parent is null.
- [X] Changes OPL to use string interpolation.
- [X] Introduces `IPropertyList` to allow extending PropertyList for other uses.
2022-06-02 10:09:53 -07:00
..
ABauble.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
AlchemistsBandage.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
AndricSatchel.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
AndrosGratitude.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
AnOldNecklace.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
AnOldRing.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
APersonalLetterAddressedToAhie.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
AsandosSatchel.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
BasinOfCrystalClearWater.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
BedlamTeleporter.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
Bleach.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
BridesLetter.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
CompletedTuitionReimbursementForm.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
CraftmansSatchel.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
CrateForSledge.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
DreadSpiderSilk.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
FragmentOfAMap.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
FragmentOfAMapDelivery.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
FriendOfTheLibraryToken.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
FriendsOfTheLibraryApplication.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
GamanHorns.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
GervisSatchel.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
GiftForArielle.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
HargroveSatchel.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
KirinBrains.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
LowelSatchel.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
MiniatureMushroom.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
MirrorOfPurification.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
MuggSatchel.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
NibbetSatchel.cs fix(core): Removes implicit cast between Serial and uint (#728) 2021-08-25 00:27:19 -07:00
NotarizedApplication.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
OfficialSealingWax.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
PeppercornFishsteak.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
PixieLeg.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
PortraitOfTheBride.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
PrismaticAmber.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
PrismaticCrystal.cs fix: Removes from literals (#893) 2021-12-24 15:56:07 -08:00
QuestGiverItem.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
RedLeatherBook.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
ReginasLetter.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
ReginasRing.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
RewardBags.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
SadrahSatchel.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
SapOfSosaria.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
SealedNotesForJamal.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
SealingWaxOrderAddressedToPetrus.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
SeveredElfEars.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
SeveredHumanEars.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
SignedTuitionReimbursementForm.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
SpecialTreatForDrithen.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
SpeckledPoisonSac.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
SpiritBottle.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
StoutWhip.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
TaintedTreeSample.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
Teleporters.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
TransparentHeart.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00
TuitionReimbursementForm.cs fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
UnicornRibs.cs fix(core): Converts more packets and switches to Moq (#415) 2021-01-16 22:09:05 -08:00