ModernUO/Projects/UOContent/Engines
Kamron Batman f77dd91811
fix: Overhauls virtue system (#1376)
## MAJOR CHANGE (API BREAKING)

Moved the virtues to it's own system _VirtueSystem_. This should make it easier to extend or remove the virtue system. Virtues will be saved to a new folder called _Virtues_.

### Motivation

The motivation was also two-fold, performance/stability, and to fix bugs.

First, virtues is the second system (first is murders), that has a pre-world-save check on _every mobile in the game_ to atrophy virtue stats. This is taxing since it freexes the world and makes world saves take longer. Every mobile had Gain/Loss dates for each virtue, whether they needed them or not. Most players don't even use the virtue system, so this will increase performance considerably.

Second, when I tried to optimize/refactor the code, I found several bugs that needed to be fixed.

### Major API Changes

- [X] The properties on players related to virtues are gone. Use `pm.GetVirtues()?.<PropertyName>` instead.
- [X] Virtues were removed from non-player Mobiles.
- [X] `pm.JusticeProtectors` was removed. Use `JusticeVirtue.GetProtector()` or `JusticeVirtue.GetProtected()` instead.

### Screenshots

<img width="221" alt="Props-1" src="https://github.com/modernuo/ModernUO/assets/3953314/5c09cb83-b8d5-44a2-b899-a7ed7cd736ac">
<img width="220" alt="props-2" src="https://github.com/modernuo/ModernUO/assets/3953314/aeade4d3-8df0-47bd-955a-a864d0946cf7">
2023-07-19 21:43:47 -07:00
..
Bulk Orders fix: Updates messages with clilocs (#1381) 2023-03-26 00:54:09 -07:00
CannedEvil fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
Chat fix: Cleans up core code (#1187) 2022-10-10 21:47:08 -07:00
ConPVP fix: Fixes NPE crash from "i wish to duel" (#1410) 2023-06-05 22:50:15 +02:00
Craft fix: Ambiguous AddRes signatures causing bad necro regs display (#1395) 2023-04-18 14:42:01 -07:00
Doom fix: Fixes doors as decorations & optimizes them (#1392) 2023-04-18 19:28:54 -07:00
Ethics fix: Updates messages with clilocs (#1381) 2023-03-26 00:54:09 -07:00
Events fix(core): Caches DateTime.NowUtc (#548) 2021-03-13 01:32:04 -08:00
Factions fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
Harvest fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
Help fix: Fixes tick count calculcations (#1366) 2023-03-09 21:00:17 -08:00
Khaldun fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
ML Quests fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
Party fix: Fixes ignoring mobs, champions, party crash, slayer rarity, boat speedhack, etc (#1222) 2022-10-31 22:16:50 -07:00
Pathing fix: Removes run flag from NPC movement (#1357) 2023-03-02 10:58:17 -08:00
Plants fix: Fixes the limitation on static tiles for harvesting (#1396) 2023-04-22 09:14:42 -07:00
Player Murder System fix: Cleans up murder system (#1428) 2023-07-16 00:04:30 -07:00
Quests fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
Spawners fix: Fixes provocation for pre-pub 16 (#1335) 2023-02-07 23:33:45 -08:00
Stealables fix: Fixes factions and makes it static (#993) 2022-05-10 11:57:37 -07:00
Treasures of Tokuno feat: Adds TextDefinition serialization support. (#1217) 2022-10-30 01:42:48 -07:00
UltimaStore fix: Replaces throttlers and packet callbacks with function pointers (#1063) 2022-06-15 12:48:43 -07:00
Veteran Rewards fix: Fixes veteran rewards (#1374) 2023-03-12 17:28:51 -07:00
Virtues fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00