ModernUO/Projects/UOContent
Kamron Batman f77dd91811
fix: Overhauls virtue system (#1376)
## MAJOR CHANGE (API BREAKING)

Moved the virtues to it's own system _VirtueSystem_. This should make it easier to extend or remove the virtue system. Virtues will be saved to a new folder called _Virtues_.

### Motivation

The motivation was also two-fold, performance/stability, and to fix bugs.

First, virtues is the second system (first is murders), that has a pre-world-save check on _every mobile in the game_ to atrophy virtue stats. This is taxing since it freexes the world and makes world saves take longer. Every mobile had Gain/Loss dates for each virtue, whether they needed them or not. Most players don't even use the virtue system, so this will increase performance considerably.

Second, when I tried to optimize/refactor the code, I found several bugs that needed to be fixed.

### Major API Changes

- [X] The properties on players related to virtues are gone. Use `pm.GetVirtues()?.<PropertyName>` instead.
- [X] Virtues were removed from non-player Mobiles.
- [X] `pm.JusticeProtectors` was removed. Use `JusticeVirtue.GetProtector()` or `JusticeVirtue.GetProtected()` instead.

### Screenshots

<img width="221" alt="Props-1" src="https://github.com/modernuo/ModernUO/assets/3953314/5c09cb83-b8d5-44a2-b899-a7ed7cd736ac">
<img width="220" alt="props-2" src="https://github.com/modernuo/ModernUO/assets/3953314/aeade4d3-8df0-47bd-955a-a864d0946cf7">
2023-07-19 21:43:47 -07:00
..
Accounting fix: Overhauls murder system (#1419) 2023-07-15 22:42:49 -07:00
Assistants feat: Moves antimacro to a configuration (#1323) 2023-01-23 21:51:05 -08:00
Commands fix: Prevent setting properties of higher privileged mobiles (#1420) 2023-07-15 22:01:33 -07:00
Compression fix: Fixes string interpolation in value string builder (#1339) 2023-02-13 23:09:50 -08:00
Configuration feat: Moves skills to json file (#1411) 2023-06-16 05:55:55 -07:00
Context Menus cleanup: Fixes bugs and cleans up code (#660) 2021-07-19 20:49:59 -07:00
Engines fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
Gumps fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
Holiday Stuff fix: Cleans up murder system (#1428) 2023-07-16 00:04:30 -07:00
Items fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
Migrations fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
Misc fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
Mobiles fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
Multis fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
Network fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
Regions fix: Drastically simplifies regions (#1400) 2023-05-19 16:39:40 -07:00
Skills fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
Special Systems fix: Fixes special scrolls (#1373) 2023-03-12 13:47:12 -07:00
Spells fix: Fixes stabled, abilities targeting self, and unsummon memory leak (#1418) 2023-07-03 09:45:22 -07:00
Targets fix: Fixes the limitation on static tiles for harvesting (#1396) 2023-04-22 09:14:42 -07:00
Utilities fix: Fixes negative numbers in commands (#1343) 2023-02-17 00:34:24 -08:00
World Saves fix: Update LabelTo, SendMessage, etc to Interpolated Strings (#1283) 2022-11-28 19:58:12 -08:00
UOContent.csproj fix: Adds migration checks to CICD, updates dependencies, adds Fedora 37, alpine 3.17 support (#1309) 2022-12-22 12:12:47 -08:00