fix(core): Fixes several serialization issues (#355)
- [X] Fixes an issue where a buffer smaller than 8 bytes would not double with enough space in some cases. - [X] Fixes an issue with dupe copying the savebuffer reference (ugh). - [X] Streamlines the IGenericWriter API to use better generics. - [X] Streamlines the IGenericReader API to use better generics. - [X] Forces `tidying` of a List/HashSet to be done externally since Writers/Readers should not have side effects. - [X] Fixes an issue where Tidying a list didn't TrimExcess, causing memory leaks. - [X] Reverted the meaning of `World.Running` to specifically refer to any world state post world loading. - NOTE: Do not use this if you want to block on world saves. Instead use checks against `WorldState.Saving` states. - [X] Fixes an issue with serializing negative DateTime deltas. - [X] Fixes a potential issue with serializing non-UTC DateTime. Bumps release version
This commit is contained in:
parent
0888ab9b86
commit
4ddb3de026
162 changed files with 652 additions and 1045 deletions
|
|
@ -426,7 +426,7 @@ namespace Server.Factions
|
|||
{
|
||||
case 0:
|
||||
{
|
||||
From = reader.ReadMobile();
|
||||
From = reader.ReadEntity<Mobile>();
|
||||
Address = Utility.Intern(reader.ReadIPAddress());
|
||||
Time = reader.ReadDateTime();
|
||||
|
||||
|
|
@ -498,7 +498,7 @@ namespace Server.Factions
|
|||
{
|
||||
case 1:
|
||||
{
|
||||
Mobile = reader.ReadMobile();
|
||||
Mobile = reader.ReadEntity<Mobile>();
|
||||
|
||||
var count = reader.ReadEncodedInt();
|
||||
Voters = new List<Voter>(count);
|
||||
|
|
@ -517,9 +517,9 @@ namespace Server.Factions
|
|||
}
|
||||
case 0:
|
||||
{
|
||||
Mobile = reader.ReadMobile();
|
||||
Mobile = reader.ReadEntity<Mobile>();
|
||||
|
||||
var mobs = reader.ReadStrongMobileList();
|
||||
var mobs = reader.ReadEntityList<Mobile>();
|
||||
Voters = new List<Voter>(mobs.Count);
|
||||
|
||||
for (var i = 0; i < mobs.Count; ++i)
|
||||
|
|
|
|||
|
|
@ -25,7 +25,7 @@ namespace Server.Factions
|
|||
{
|
||||
case 0:
|
||||
{
|
||||
Item = reader.ReadItem();
|
||||
Item = reader.ReadEntity<Item>();
|
||||
Expiration = reader.ReadDateTime();
|
||||
break;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -61,7 +61,7 @@ namespace Server.Factions
|
|||
{
|
||||
m_Faction = Faction.ReadReference(reader);
|
||||
|
||||
m_Commander = reader.ReadMobile();
|
||||
m_Commander = reader.ReadEntity<Mobile>();
|
||||
|
||||
if (version < 5)
|
||||
{
|
||||
|
|
@ -136,7 +136,7 @@ namespace Server.Factions
|
|||
|
||||
for (var i = 0; i < factionTrapCount; ++i)
|
||||
{
|
||||
if (reader.ReadItem() is BaseFactionTrap trap && !trap.CheckDecay())
|
||||
if (reader.ReadEntity<Item>() is BaseFactionTrap trap && !trap.CheckDecay())
|
||||
{
|
||||
Traps.Add(trap);
|
||||
}
|
||||
|
|
|
|||
|
|
@ -43,7 +43,7 @@ namespace Server.Factions
|
|||
}
|
||||
case 0:
|
||||
{
|
||||
Mobile = reader.ReadMobile();
|
||||
Mobile = reader.ReadEntity<Mobile>();
|
||||
|
||||
m_KillPoints = reader.ReadEncodedInt();
|
||||
m_MerchantTitle = (MerchantTitle)reader.ReadEncodedInt();
|
||||
|
|
|
|||
|
|
@ -39,8 +39,8 @@ namespace Server.Factions
|
|||
Town = Town.ReadReference(reader);
|
||||
Owner = Faction.ReadReference(reader);
|
||||
|
||||
m_Sheriff = reader.ReadMobile();
|
||||
m_Finance = reader.ReadMobile();
|
||||
m_Sheriff = reader.ReadEntity<Mobile>();
|
||||
m_Finance = reader.ReadEntity<Mobile>();
|
||||
|
||||
Town.State = this;
|
||||
|
||||
|
|
|
|||
|
|
@ -128,7 +128,7 @@ namespace Server.Factions
|
|||
{
|
||||
Town = Town.ReadReference(reader);
|
||||
Faction = Faction.ReadReference(reader);
|
||||
m_Sigil = reader.ReadItem() as Sigil;
|
||||
m_Sigil = reader.ReadEntity<Sigil>();
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -429,7 +429,7 @@ namespace Server.Factions
|
|||
m_Corrupted = Faction.ReadReference(reader);
|
||||
m_Corrupting = Faction.ReadReference(reader);
|
||||
|
||||
LastMonolith = reader.ReadItem() as BaseMonolith;
|
||||
LastMonolith = reader.ReadEntity<BaseMonolith>();
|
||||
|
||||
LastStolen = reader.ReadDateTime();
|
||||
GraceStart = reader.ReadDateTime();
|
||||
|
|
|
|||
|
|
@ -255,7 +255,7 @@ namespace Server.Factions
|
|||
var version = reader.ReadInt();
|
||||
|
||||
Faction = Faction.ReadReference(reader);
|
||||
Placer = reader.ReadMobile();
|
||||
Placer = reader.ReadEntity<Mobile>();
|
||||
TimeOfPlacement = reader.ReadDateTime();
|
||||
|
||||
if (Visible)
|
||||
|
|
|
|||
|
|
@ -522,7 +522,7 @@ namespace Server.Factions
|
|||
|
||||
var version = reader.ReadInt();
|
||||
|
||||
Rider = reader.ReadMobile();
|
||||
Rider = reader.ReadEntity<Mobile>();
|
||||
|
||||
if (Rider == null)
|
||||
{
|
||||
|
|
|
|||
|
|
@ -74,7 +74,7 @@ namespace Server.Factions.AI
|
|||
{
|
||||
case 1:
|
||||
{
|
||||
Follow = reader.ReadMobile();
|
||||
Follow = reader.ReadEntity<Mobile>();
|
||||
goto case 0;
|
||||
}
|
||||
case 0:
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue