Commit graph

1829 commits

Author SHA1 Message Date
Crome696
1bf9c263d5 fix(items): normalize Reactive Paralyze values 2026-07-12 09:16:01 +02:00
Crome696
c82b826137 feat(items): add Reactive Paralyze property 2026-07-12 09:16:01 +02:00
Crome696
519e8debbd feat(items): add Bone Breaker property 2026-07-11 23:15:46 +02:00
Crome696
8a02a60f80 fix(items): preserve BaseWeapon migrations after rebase 2026-07-11 22:22:13 +02:00
Crome696
c71bf47be8 fix(items): restrict resonance aggregation hosts 2026-07-11 22:22:13 +02:00
Crome696
7d50457e4a feat(items): add SA resonance property 2026-07-11 22:22:13 +02:00
Crome696
d8b9a2ca62 feat(items): implement Unwieldy negative property 2026-07-11 15:53:43 +02:00
Crome696
e9d0d85385 feat(items): implement antique property 2026-07-11 09:49:27 +02:00
Crome696
9174917ca6 Add Talking to Wisps talisman 2026-07-11 09:48:01 +02:00
Crome696
7f40274c5c refactor: keep Spell Focusing reusable without sash 2026-07-10 23:28:04 +02:00
Crome696
dfee8f09c5 fix: tighten Spell Focusing Sash cleanup 2026-07-10 23:28:04 +02:00
Crome696
f040f1b69c feat: implement Spell Focusing Sash 2026-07-10 23:28:04 +02:00
Crome696
8cba41fb2a feat: implement Focus weapon property 2026-07-10 22:02:14 +02:00
Crome696
57774b1f38 feat: implement Wildfire spell 2026-07-10 22:01:14 +02:00
Crome696
a969ac0d45 feat: add Damage Eater armor properties 2026-07-10 16:59:40 +02:00
Crome696
7a40f7f0a7 fix: tighten Arcane Empowerment damage hooks 2026-07-10 16:54:09 +02:00
Crome696
434950ba49 feat: implement Arcane Empowerment 2026-07-10 16:54:09 +02:00
Crome696
8eafdd7605 test: harden Rising Colossus restrictions 2026-07-10 16:23:32 +02:00
Crome696
c83fb6fe1d feat: implement Rising Colossus 2026-07-10 16:23:32 +02:00
Crome696
0f2d83eb3d feat: implement Spell Trigger 2026-07-10 16:07:36 +02:00
Crome696
bfd6284eac test: make Soul Charge shield fixture explicit 2026-07-10 15:11:58 +02:00
Crome696
025f35ce68 test: cover zero chance Soul Charge 2026-07-10 15:11:58 +02:00
Crome696
f38d564ad6 feat: implement Soul Charge shield property 2026-07-10 15:11:58 +02:00
Crome696
cd526022fa feat: implement mysticism enchant spell 2026-07-10 14:28:00 +02:00
Crome696
1ad7593ddd feat: apply Spell Focusing to eligible spell damage 2026-07-10 09:44:28 +02:00
Crome696
84e73b81c8 feat: add Spell Focusing item property storage 2026-07-10 09:44:28 +02:00
Crome696
b048bc9813 feat: implement Healing Stone spell 2026-07-10 07:51:14 +02:00
Crome696
e8e439c373 feat: implement Purge Magic 2026-07-09 21:05:49 +02:00
Crome696
6b3a7d65e8 test(items): cover craft exceptional talisman bonus 2026-07-09 20:48:16 +02:00
Crome696
72ca6b1821
Merge pull request #40 from RebirthUO/feat/issue-36-dryad-allure
feat: add Dryad Allure spell
2026-07-09 20:35:51 +02:00
Crome696
010dbf3683 feat: add Dryad Allure spell 2026-07-09 20:30:18 +02:00
Crome696
7e2be0c324 feat: add last parry chance tooltip 2026-07-09 20:29:15 +02:00
Crome696
5c3ea8b598 feat: add Nether Bolt mysticism spell 2026-07-09 19:44:40 +02:00
Crome696
5810ce85cb feat(items): add Splintering Weapon property 2026-07-09 19:25:47 +02:00
Crome696
407fdd59b7 feat(items): add Swarm weapon property 2026-07-09 14:50:02 +02:00
Crome696
238c593ec4 feat(items): add Casting Focus property 2026-07-09 14:07:07 +02:00
Crome696
d4091e940d feat(items): add Brittle negative property 2026-07-09 10:24:19 +02:00
Crome696
0a8bd69adb feat(items): add Massive negative property 2026-07-09 08:29:26 +02:00
Crome696
d163761dcd feat(items): add Blood Drinker property 2026-07-09 08:10:12 +02:00
Crome696
a44cfbd5c9 feat(items): add Sparks weapon property 2026-07-08 23:43:57 +02:00
Crome696
b03a6ab91b feat(items): add Prized negative property 2026-07-08 23:10:13 +02:00
Crome696
237ac1644e feat(items): enable Storm Caller Battle Lust 2026-07-08 22:45:33 +02:00
Crome696
4ef61e0b11 feat(items): add extended weapon attributes 2026-07-08 22:28:16 +02:00
Crome696
d1580614e0 fix(items): harden Battle Lust cleanup 2026-07-08 19:32:11 +02:00
Crome696
4d9a7f815f feat(items): implement Battle Lust property 2026-07-08 19:15:53 +02:00
Crome696
3b3634036b feat(items): implement Bane weapon property 2026-07-08 15:19:05 +02:00
Kamron Batman
191d3f3f33
feat(throwing): add remaining SA throwing artifacts (add-only) (#2516)
Adds the four remaining named Stygian Abyss throwing artifacts as item definitions, completing the throwing artifact set (7/7 now defined in ModernUO).

## Added (stat-for-stat from ServUO)
- **Abyss Reaver** (Cyclone) — random Throwing +5..10 skill bonus, +25..35 damage, Exorcism slayer
- **Storm Caller** (Boomerang) — Hit Lightning / Hit Lower Defense, 20/20/20/20/20 elemental split
- **Banshee's Call** (Cyclone) — Hit Harm / Hit Life Leech, 100% cold, Velocity 35
- **Wind of Corruption** (Cyclone) — Hit Stamina Leech / Hit Lower Defense, 100% chaos, Fey slayer

## Acquisition — deferred (documented)
These are **`[add`-only for now**. Their OSI sources aren't in ModernUO yet:
- Abyss Reaver → the Into the Void quest (Agralem), deferred with the Abyss void-creature content.
- Storm Caller / Banshee's Call / Wind of Corruption → renowned/boss creatures (`WyvernRenowned`, `PrimevalLich`, etc.) that need a `BaseRenowned` framework port.

Per direction, the items are worth defining now; wiring their drops follows later.

## Notes
- Storm Caller's ServUO `WeaponAttributes.BattleLust = 1` is left as a `//TODO Implement BattleLust` — the attribute doesn't exist in ModernUO's `AosWeaponAttribute` set yet.
- The human Bow variant `WindOfCorruptionHuman` is archery, not throwing — intentionally out of scope.

Server builds clean.
2026-07-03 08:50:16 -07:00
Kamron Batman
158e7f2e5f
feat(throwing): add Ter Mur reptiles (Raptor + slith family) and their SA claws (#2515)
Follow-up to the gargoyle Throwing work (#2510/#2512/#2514). Ports two Stygian Abyss creatures from ServUO so two of the throwing artifacts finally have a real OSI drop source instead of being `[add`-only.

## Changes
- **`Raptor`** and **`StoneSlith`** — ported stat-for-stat from ServUO. They **spawn automatically**: `Distribution/Data/Spawns/post-uoml/termur/TerMur.json` already contained Raptor/StoneSlith spawner entries referencing these class names, so no spawn-file edits were needed.
- **`RaptorClaw`** (Boomerang-based) and **`StoneSlithClaw`** (Cyclone-based) artifacts, dropped from each creature's `OnDeath` at ServUO's 0.5% rate (uncontrolled only).
- StoneSlith retains its `GraspingClaw` monster ability; both use `BleedAttack`.

## ModernUO idioms
Default range perception (16) / fight range, derived `GetSpeeds` (no `SetSpeed`), `[SerializationGenerator(0)]` codegen, collection-expression arrays.

## Documented omissions vs ServUO
Flagged as TODO in-code — all are content missing from ModernUO, not silent drops: Raptor's friend-spawn timer + its 25% `AncientPotteryFragments` drop; StoneSlith's `TailSwipe`, `DragonBlood`, and `SlithEye`/`TatteredAncientScroll`/`AncientPotteryFragments` drops; plus `HideType.Horned/Spined` and `PackInstinct.Ostard` (no ModernUO equivalents yet).

## Not included
The other three throwing artifacts (Storm Caller, Banshee's Call, Wind of Corruption) drop from renowned/boss creatures via a `BaseRenowned` artifact-list system that doesn't exist in ModernUO yet — a separate, larger effort. AbyssReaver stays with the (deferred) Into-the-Void quest.

Verified: server builds clean; throwing suite 14/14.
2026-07-02 23:58:29 -07:00
Kamron Batman
a706ef1449
fix(ci): run test projects on CI; remove brittle OPL attribute tests (#2513)
## Problem

Three coupled issues, each hiding the next:

1. **CI passed despite failing tests, with no test logs.** ([example run](https://github.com/modernuo/ModernUO/actions/runs/28639143286/job/84931544255) — the `Test` step produced zero output and the job went green.)
2. **Two `EmitsLowerStatReqWhenPassed` tests** fail with `KeyNotFoundException: '1060435'`.
3. Once CI actually ran the tests, **~337 UOContent tests failed** with `FileNotFoundException: tiledata.mul was not found` — the test bootstrap force-loaded copyrighted client data that CI doesn't have.

## Root causes & fixes

### 1. CI ran zero tests (`fix(ci)`)
The `Test` step ran `dotnet test --no-restore`, but the `Build` step only restores/builds `Application` — never the test projects. Without a restore, the test projects have no `project.assets.json`, so `Microsoft.NET.Test.Sdk`'s targets aren't imported, they aren't recognized as test projects, and `dotnet test` runs the `VSTest` target against **zero** projects → no output, **exit 0**.

- Both jobs now run `dotnet test --logger trx --results-directory ./TestResults` (test projects restore and run) **plus a guard** that fails the job if no `.trx` is produced — a permanent backstop against silent zero-test passes.

### 2. Impossible OPL tests (`fix(ci)` + `test(opl)`)
#2501 deliberately emits `LowerStatReq` (`1060435`) **inline in each item**, not in `GetProperties`. A follow-up "fix" dropped the `lowerStatReq:` argument to make the tests compile but left the assertions expecting `1060435`.

- Removed the two impossible tests, then removed the **entire `Tests/PropertyList/` OPL attribute set** from #2501: these assert exact cliloc/value/order of OPL emission per item base — a one-time proof of the #2501 rewire, now a permanent tax on modding (any admin reorder/value change/added line reddens the build). The one non-trivial case (LowerStatReq) is what just broke, because the test was wrong. Inline emission stays covered by the `BaseArmor`/`BaseClothing` tests.

### 3. Tile-data-dependent tests crashed CI (`test(uocontent)`)
UOContent.Tests' collection-fixture constructor force-loaded `tiledata.mul` unconditionally. On CI (no client files) it threw, and xUnit failed **every test in the collection** with the same error — mostly collateral (packet/scheduler/spawner tests that don't need tile data).

- Mirror Server.Tests' graceful pattern: `TestServerInitializer` probes for `tiledata.mul` and only loads tile/multi data (and runs the tile-dependent configure steps) when present, exposing `TileDataLoaded` so the fixture no longer throws.
- Add a shared `TileDataRequirement.SkipIfMissing()` guard and apply it to exactly the **31** pathfinding/multi/AI tests that genuinely need real tile data (`[SkippableFact]`/`[SkippableTheory]`).

## Verification (all local)

| Scenario | Server.Tests | UOContent.Tests |
|---|---|---|
| **Client data absent (CI)** | 726 pass, 17 skip, **0 fail** | 469 pass, 32 skip, **0 fail** |
| **Client data present (dev)** | 726 pass, 0 skip, **0 fail** | 501 pass, 0 skip, **0 fail** |

- Full `dotnet test` exits **0**; TRX files produced; the no-test guard trips (exit 1) only when zero `.trx` are produced.
2026-07-02 22:35:37 -07:00
Kamron Batman
8c6eab5fca
feat(throwing): wire SA loot flavor + Valkyrie's Glaive stealable (#2512)
Phase 2 follow-up to #2510 — wires acquisition for the gargoyle Throwing content that Phase 1 deliberately left out.

## Changes
- **SA loot flavor (`IsStygian`)** — completes the dead loot path from the original PR: adds `SAWeaponTypes`/`SARangedWeaponTypes` pools + `isStygian` branches to `Loot.RandomWeapon`/`RandomRangedWeapon`, **and** the missing piece — computes `IsStygian` (`map == Map.TerMur`) in `LootPackEntry.Construct` and threads it through `LootPackItem.Construct`. Ter Mur creatures now roll SA gear + the three throwing weapons (Boomerang/Cyclone/SoulGlaive) from their normal `BaseWeapon`/`BaseRanged` loot entries. Conservative `TerMur`-only (not ServUO's extra `|| RandomBool()`).
- **Valkyrie's Glaive** — re-added as a self-contained Ter Mur stealable artifact at `(843, 665, 27)`, matching ServUO/OSI, with the previously-missing `ArtifactRarity => 5`.

## Deferred (documented)
The 5 host-dependent artifacts (Raptor Claw, Stone Slith Claw, Storm Caller, Banshee's Call, Wind of Corruption) are intentionally NOT included — their OSI drop sources (Raptor, StoneSlith, and the renowned/boss creatures + a `BaseRenowned` artifact-list system) don't exist in ModernUO yet, so re-adding the items now would leave them `[add`-only. They'll follow a dedicated SA-creatures effort.

## Notes
- No new tests: both changes are property/plumbing with RNG-driven output — no deterministic complex logic to assert (consistent with the repo's test-scope conventions).
- Verified: server + test project compile; throwing suite 14/14.
2026-07-02 22:28:55 -07:00