ModernUO/Projects/UOContent
Kamron Batman 26f784f45d
fix: Overhauls murder system (#1419)
## MAJOR CHANGE (API BREAKING)

Added a player murder system to facilitate reporting murders. This should make it easier to extend to create a bounty system or  other related game content. Player murders will be saved in a folder called _PlayerMurders_.

### Motivation

The motivation was two-fold, performance, and bug fixes.

First, murders are one of two systems that do a pre-world-save check on _every mobile in the game_ to decay kills and set their expiring murders. This is taxing since it freezes the world and makes world saves take longer. Every mobile has ShortTermMurders even though it is a player concept. And next, 90%+ of players are not murderers but had an ever increasing MurderElapse time that was being tracked against GameTime. These properties were also serialized unnecessarily for all mobs.

Second, when I tried to optimize/refactor the code, it was obvious that the system has bugs.

### Major API Changes
- [X] Created a player murder system and moved `ShortTermMurders`, `ShortTermElapse`, and `LongTermElapse` to the system.
- [X] Added convenience property `PlayerMobile.ShortTermMurders`.
- [X] Added convenience properties `PlayerMobile.ShortTermMurderExpiration` and `PlayerMobile.LongTermMurderExpiration`
- [X] Moved ReportMurdererGump.cs
- [X] Adds an `EventSink.PlayerDeleted` event.

### Notes
The system currently does not support NPCs. To support expiring murders on NPCs I highly recommend a different architecture for large servers (500k+ mobs including players). Specifically switching from looping through all MurderContext to a time-order link list.
2023-07-15 22:42:49 -07:00
..
Accounting fix: Overhauls murder system (#1419) 2023-07-15 22:42:49 -07:00
Assistants feat: Moves antimacro to a configuration (#1323) 2023-01-23 21:51:05 -08:00
Commands fix: Prevent setting properties of higher privileged mobiles (#1420) 2023-07-15 22:01:33 -07:00
Compression fix: Fixes string interpolation in value string builder (#1339) 2023-02-13 23:09:50 -08:00
Configuration feat: Moves skills to json file (#1411) 2023-06-16 05:55:55 -07:00
Context Menus cleanup: Fixes bugs and cleans up code (#660) 2021-07-19 20:49:59 -07:00
Engines fix: Overhauls murder system (#1419) 2023-07-15 22:42:49 -07:00
Gumps fix: Overhauls murder system (#1419) 2023-07-15 22:42:49 -07:00
Holiday Stuff fix: Removes PoolOfAcid (#1310) 2022-12-22 13:20:34 -08:00
Items fix: Fixes NPE in boomerang (#1426) 2023-07-15 10:07:35 -07:00
Migrations fix: Overhauls murder system (#1419) 2023-07-15 22:42:49 -07:00
Misc fix: Overhauls murder system (#1419) 2023-07-15 22:42:49 -07:00
Mobiles fix: Overhauls murder system (#1419) 2023-07-15 22:42:49 -07:00
Multis fix: Fixes drydocking when EffectItem type items are on the deck (#1416) 2023-06-27 18:12:58 -07:00
Network fix: Fixes tick count calculcations (#1366) 2023-03-09 21:00:17 -08:00
Regions fix: Drastically simplifies regions (#1400) 2023-05-19 16:39:40 -07:00
Skills fix: Fixes crash with antimacro code (#1415) 2023-06-23 17:10:47 -07:00
Special Systems fix: Fixes special scrolls (#1373) 2023-03-12 13:47:12 -07:00
Spells fix: Fixes stabled, abilities targeting self, and unsummon memory leak (#1418) 2023-07-03 09:45:22 -07:00
Targets fix: Fixes the limitation on static tiles for harvesting (#1396) 2023-04-22 09:14:42 -07:00
Utilities fix: Fixes negative numbers in commands (#1343) 2023-02-17 00:34:24 -08:00
World Saves fix: Update LabelTo, SendMessage, etc to Interpolated Strings (#1283) 2022-11-28 19:58:12 -08:00
UOContent.csproj fix: Adds migration checks to CICD, updates dependencies, adds Fedora 37, alpine 3.17 support (#1309) 2022-12-22 12:12:47 -08:00