ModernUO/Projects/UOContent/Items/Weapons/Abilities
Kamron Batman 843a29e7dc
refactor: master views over BaseCreature's one master reference (#2674)
## Summary

After #2670, `BaseCreature` stores one master. Callers still reached it through three differently gated names plus hand-rolled combinations of the `Controlled`/`Summoned` flags. Each gate is now one named view:

| Member | Definition | Meaning |
|---|---|---|
| `Master` | the reference; its setter does the follower bookkeeping; serialized as before | whoever the creature answers to |
| `ControlMaster` | `Controlled ? Master : null` | the owner |
| `SummonMaster` | `Summoned ? Master : null` | the summoner |
| `GetMaster()` | `ControlMaster ?? SummonMaster` | who answers for the creature |

`ControlMaster` and `SummonMaster` stay settable so custom code keeps compiling: both setters assign `Master`. There is no guard, so a write through either one can read back as null until the matching flag is set.

An enraged creature is the one shape with a master and neither flag. It keeps its meer through `Master`, while `GetMaster()` stays null, so the meer never answers for it (notoriety, kill credit).

Readers move onto the view they mean:
- "Owner or summoner" pairs and `ControlMaster ?? SummonMaster` collapse into `GetMaster()`: pack instinct, familiars, golem, house access, mounts, pack horse, Solen friendship, spell target and guild checks, and the `[` pet command.
- Checks such as `Controlled && ControlMaster == from` drop the flag the view already applies. Checks that don't reduce keep it: `Controlled && ControlMaster != from`, a possibly-null `from`, and `MageAI.CanDispel`'s `Summoned &&`.

**No behavior change, save format unchanged** (the schema generator produces no diff). Edge cases for custom code and shard operators:
- `SummonMaster = x` on a plain pet now replaces its owner (#2670 made that a no-op), and `ControlMaster = null` on an uncontrolled summon now clears its caster (it did nothing before).
- `SpellHelper.GetGuildFor` no longer falls back to an enraged creature's meer. Meer mages have no guild.

## Docs

- `dev-docs/content-patterns.md` § Masters: which view answers which question, how to set a master, and which flag checks are redundant.
- `dev-docs/runuo-migration-docs/09-items-mobiles-creatures.md` § Masters: RunUO's two-field reads mapped onto the views, plus the gotcha for creatures that set `SummonMaster` without `Summoned` (the write compiles, the read now returns null; use `Master`).
- The `modernuo-content-patterns` and `migrate-items-mobiles` skills point at both.

## Test plan

- [x] `MasterViewsTests`: all four views across wild, pet, controlled summon, uncontrolled summon and enraged shapes; reassigning `Master` moves follower slots; `SetControlMaster(null)` keeps an uncontrolled summon's caster; deleting a summon returns the caster's slots
- [x] Serialization tests updated to the new views (round-trip, legacy v22, v23 migration)
- [x] UOContent.Tests (1178 passed, 2 skipped) and Server.Tests (907) green
2026-09-24 22:45:24 -07:00
..
ArmorIgnore.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
ArmorPierce.cs fix: Fixes WeaponAbility GetTactics override (#1778) 2024-05-18 10:24:29 -07:00
Bladeweave.cs fix: Fixes WeaponAbility GetTactics override (#1778) 2024-05-18 10:24:29 -07:00
BleedAttack.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
Block.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
ConcussionBlow.cs fix: Fixes boat movement & moves weapon ability out of core (#750) 2021-08-30 21:30:09 -07:00
CrushingBlow.cs fix: Fixes WeaponAbility GetTactics override (#1778) 2024-05-18 10:24:29 -07:00
DefenseMastery.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
Disarm.cs fix: Fixes buffs don't start/stop properly. Streamlines constructor and Add/Remove buffs. (#2082) 2025-01-24 18:20:23 -08:00
Dismount.cs refactor: master views over BaseCreature's one master reference (#2674) 2026-09-24 22:45:24 -07:00
DoubleShot.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
DoubleStrike.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
DualWield.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
Feint.cs fix: Fixes Feint so it properly reduces damage (#1657) 2024-01-11 00:01:52 -08:00
ForceArrow.cs chore: Use var everywhere (#2294) 2025-12-27 16:47:28 -08:00
ForceOfNature.cs chore: Use var everywhere (#2294) 2025-12-27 16:47:28 -08:00
FrenziedWhirlwind.cs chore: Use var everywhere (#2294) 2025-12-27 16:47:28 -08:00
InfectiousStrike.cs feat: Refactor Poison system, implement Darkglow & Parasitic effects (#2385) 2026-03-21 21:27:22 -07:00
InfusedThrow.cs chore: Use var everywhere (#2294) 2025-12-27 16:47:28 -08:00
LightningArrow.cs chore: Use var everywhere (#2294) 2025-12-27 16:47:28 -08:00
MortalStrike.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
MovingShot.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
MysticArc.cs chore: Use var everywhere (#2294) 2025-12-27 16:47:28 -08:00
NerveStrike.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
ParalyzingBlow.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
PsychicAttack.cs fix: Fixes buffs don't start/stop properly. Streamlines constructor and Add/Remove buffs. (#2082) 2025-01-24 18:20:23 -08:00
RidingSwipe.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
SerpentArrow.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
ShadowStrike.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
TalonStrike.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
WeaponAbility.cs chore: Use var everywhere (#2294) 2025-12-27 16:47:28 -08:00
WeaponAbilityPackets.cs fix: Fixes ignoring mobs, champions, party crash, slayer rarity, boat speedhack, etc (#1222) 2022-10-31 22:16:50 -07:00
WhirlwindAttack.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00