ModernUO/Projects/UOContent/Mobiles/Abilities
Kamron Batman 69ff5f3940
fix: champion minions belong to their spawn (#2717)
Stacked on #2716. Retarget to `main` after it merges.

## Problem
Mobiles a champion summons mid-fight aren't tracked by anything:

| Summoner | Minions |
|---|---|
| LordOaks | Silvani queen |
| `SummonPixiesCounter` (LordOaks, Silvani, Twaulo) | 3-6 pixies per trigger |
| Barracoon | 3-6 ratmen per trigger |

`ChampionSpawn.DeleteCreatures` (called on expiry and when the spawn is deleted) clears only `Creatures` and the champion. These minions survive every reset and stay in the save. I surveyed every content creature that creates other mobiles; the others already clean up after themselves: Meraktus deletes its followers, Harrower kills its tentacles, PlagueSpawn and the Enraged animals delete themselves when their owner is gone, and BogThing eats its boglings.

## Changes
- **`BaseCreature.SpawnMinion(minion, target, location)`:** sets the team, places the minion and sets its combatant. Ownership: if the summoner is a champion spawn's champion, one of its creatures, or one of its minions (found through the spawn region), the minion joins that spawn. It refuses, and deletes the minion, if the summoner isn't on a real map. `SummonPixiesCounter` read `source.Map` even though `MonsterAbility.Trigger` notes it can fire after the creature has left the world.
- **`ChampionSpawn.Minions`:** a new serialized list (v12, `MigrateFrom(V11Content)`) kept apart from `Creatures`:
  - killing a minion never counts toward a level, so a leftover summoner can't feed a restarted spawn;
  - `DeleteCreatures` deletes minions along with the creatures, which matches when the spawn is deactivated (`ExpireCreatures`, 10 minutes after `Stop`) or deleted.
- **Callers:** LordOaks, `SummonPixiesCounter` and Barracoon spawn through `SpawnMinion`. A summoner that isn't part of a spawn (a GM `[add]`) still makes standalone minions, as today.

## Testing
- `ChampionMinionTests`:
  - the champion's queen is listed in `Minions` and deleted by `DeleteCreatures`;
  - a minion's minion also belongs to the spawn;
  - a Lord Oaks in the region that isn't the spawn's champion keeps a standalone queen.
- UOContent.Tests: 1237 passed, 2 skipped. The Application build is clean.
2026-10-18 17:48:31 -07:00
..
Fire Breath feat: Adds ability groups, DOT abilities, and combat abilities (#1264) 2022-11-23 12:33:27 -08:00
Summon Undead refactor: master views over BaseCreature's one master reference (#2674) 2026-09-24 22:45:24 -07:00
AreaEffectMonsterAbility.cs fix: Adds guard for monster ability recursion (#2363) 2026-03-12 19:26:49 -07:00
BloodBathAttack.cs fix: Fixes Dot abilities. Adds blood bath attack (#1277) 2022-11-23 19:40:48 -08:00
ColossalBlow.cs fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
DeathExplosion.cs fix: Adds guard for monster ability recursion (#2363) 2026-03-12 19:26:49 -07:00
DestroyEquipment.cs fix: Streamlines insurance. Insurance only executes when enabled. (#2550) 2026-07-26 09:47:49 -07:00
DrainLifeAreaAttack.cs feat: Adds drain life ability (#1181) 2022-10-02 11:36:15 -07:00
DrainLifeAttack.cs fix: Fixes Dot abilities. Adds blood bath attack (#1277) 2022-11-23 19:40:48 -08:00
EnergyBoltCounter.cs fix: Fixes single target abilities. Adds drain life ability. (#1276) 2022-11-23 19:06:27 -08:00
FanningFire.cs feat: Adds SpecialAttack monster ability trigger. Fixes fanning fire. (#2186) 2025-05-15 22:14:52 -07:00
FanThrowCounter.cs fix: Fixes single target abilities. Adds drain life ability. (#1276) 2022-11-23 19:06:27 -08:00
GraspingClaw.cs fix: Fixes Dot abilities. Adds blood bath attack (#1277) 2022-11-23 19:40:48 -08:00
MagicalBarrier.cs fix: Fixes magical barrier NPE and an edge case (#2162) 2025-04-22 17:52:09 -07:00
MonsterAbilities.cs feat(throwing): add Ter Mur reptiles (Raptor + slith family) and their SA claws (#2515) 2026-07-02 23:58:29 -07:00
MonsterAbility.cs fix: monster ability queries no longer have side effects (#2716) 2026-10-18 17:41:27 -07:00
MonsterAbilityGroup.cs fix: Cleans up potential memory leak in monster abilities. (#2185) 2025-05-15 19:42:54 -07:00
MonsterAbilitySingleTarget.cs fix: Fixes single target abilities. Adds drain life ability. (#1276) 2022-11-23 19:06:27 -08:00
MonsterAbilitySingleTargetDoT.cs fix: Timer Remaining Count off by 1 fix (#2046) 2025-01-01 20:19:38 -08:00
MonsterAbilityTrigger.cs feat: Adds magical barrier and ebolt counter ability (#1182) 2022-10-02 20:48:53 -07:00
MonsterAbilityType.cs feat(throwing): add Ter Mur reptiles (Raptor + slith family) and their SA claws (#2515) 2026-07-02 23:58:29 -07:00
PoisonGasAreaAttack.cs feat: Adds magical barrier and ebolt counter ability (#1182) 2022-10-02 20:48:53 -07:00
PoisonGasCounter.cs fix: Fixes single target abilities. Adds drain life ability. (#1276) 2022-11-23 19:06:27 -08:00
ReflectPhysicalDamage.cs fix: Cleans up potential memory leak in monster abilities. (#2185) 2025-05-15 19:42:54 -07:00
RuneCorruption.cs fix: Fixes Dot abilities. Adds blood bath attack (#1277) 2022-11-23 19:40:48 -08:00
StunAttack.cs fix: Fixes NPE with stun attack (#1751) 2024-04-30 19:20:06 -07:00
SummonPixiesCounter.cs fix: champion minions belong to their spawn (#2717) 2026-10-18 17:48:31 -07:00
TailSwipe.cs feat(throwing): add Ter Mur reptiles (Raptor + slith family) and their SA claws (#2515) 2026-07-02 23:58:29 -07:00
ThrowHatchetCounter.cs fix: Fixes single target abilities. Adds drain life ability. (#1276) 2022-11-23 19:06:27 -08:00