ModernUO/Projects/UOContent/Mobiles/Abilities
Kamron Batman 843a29e7dc
refactor: master views over BaseCreature's one master reference (#2674)
## Summary

After #2670, `BaseCreature` stores one master. Callers still reached it through three differently gated names plus hand-rolled combinations of the `Controlled`/`Summoned` flags. Each gate is now one named view:

| Member | Definition | Meaning |
|---|---|---|
| `Master` | the reference; its setter does the follower bookkeeping; serialized as before | whoever the creature answers to |
| `ControlMaster` | `Controlled ? Master : null` | the owner |
| `SummonMaster` | `Summoned ? Master : null` | the summoner |
| `GetMaster()` | `ControlMaster ?? SummonMaster` | who answers for the creature |

`ControlMaster` and `SummonMaster` stay settable so custom code keeps compiling: both setters assign `Master`. There is no guard, so a write through either one can read back as null until the matching flag is set.

An enraged creature is the one shape with a master and neither flag. It keeps its meer through `Master`, while `GetMaster()` stays null, so the meer never answers for it (notoriety, kill credit).

Readers move onto the view they mean:
- "Owner or summoner" pairs and `ControlMaster ?? SummonMaster` collapse into `GetMaster()`: pack instinct, familiars, golem, house access, mounts, pack horse, Solen friendship, spell target and guild checks, and the `[` pet command.
- Checks such as `Controlled && ControlMaster == from` drop the flag the view already applies. Checks that don't reduce keep it: `Controlled && ControlMaster != from`, a possibly-null `from`, and `MageAI.CanDispel`'s `Summoned &&`.

**No behavior change, save format unchanged** (the schema generator produces no diff). Edge cases for custom code and shard operators:
- `SummonMaster = x` on a plain pet now replaces its owner (#2670 made that a no-op), and `ControlMaster = null` on an uncontrolled summon now clears its caster (it did nothing before).
- `SpellHelper.GetGuildFor` no longer falls back to an enraged creature's meer. Meer mages have no guild.

## Docs

- `dev-docs/content-patterns.md` § Masters: which view answers which question, how to set a master, and which flag checks are redundant.
- `dev-docs/runuo-migration-docs/09-items-mobiles-creatures.md` § Masters: RunUO's two-field reads mapped onto the views, plus the gotcha for creatures that set `SummonMaster` without `Summoned` (the write compiles, the read now returns null; use `Master`).
- The `modernuo-content-patterns` and `migrate-items-mobiles` skills point at both.

## Test plan

- [x] `MasterViewsTests`: all four views across wild, pet, controlled summon, uncontrolled summon and enraged shapes; reassigning `Master` moves follower slots; `SetControlMaster(null)` keeps an uncontrolled summon's caster; deleting a summon returns the caster's slots
- [x] Serialization tests updated to the new views (round-trip, legacy v22, v23 migration)
- [x] UOContent.Tests (1178 passed, 2 skipped) and Server.Tests (907) green
2026-09-24 22:45:24 -07:00
..
Fire Breath feat: Adds ability groups, DOT abilities, and combat abilities (#1264) 2022-11-23 12:33:27 -08:00
Summon Undead refactor: master views over BaseCreature's one master reference (#2674) 2026-09-24 22:45:24 -07:00
AreaEffectMonsterAbility.cs fix: Adds guard for monster ability recursion (#2363) 2026-03-12 19:26:49 -07:00
BloodBathAttack.cs fix: Fixes Dot abilities. Adds blood bath attack (#1277) 2022-11-23 19:40:48 -08:00
ColossalBlow.cs fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
DeathExplosion.cs fix: Adds guard for monster ability recursion (#2363) 2026-03-12 19:26:49 -07:00
DestroyEquipment.cs fix: Streamlines insurance. Insurance only executes when enabled. (#2550) 2026-07-26 09:47:49 -07:00
DrainLifeAreaAttack.cs feat: Adds drain life ability (#1181) 2022-10-02 11:36:15 -07:00
DrainLifeAttack.cs fix: Fixes Dot abilities. Adds blood bath attack (#1277) 2022-11-23 19:40:48 -08:00
EnergyBoltCounter.cs fix: Fixes single target abilities. Adds drain life ability. (#1276) 2022-11-23 19:06:27 -08:00
FanningFire.cs feat: Adds SpecialAttack monster ability trigger. Fixes fanning fire. (#2186) 2025-05-15 22:14:52 -07:00
FanThrowCounter.cs fix: Fixes single target abilities. Adds drain life ability. (#1276) 2022-11-23 19:06:27 -08:00
GraspingClaw.cs fix: Fixes Dot abilities. Adds blood bath attack (#1277) 2022-11-23 19:40:48 -08:00
MagicalBarrier.cs fix: Fixes magical barrier NPE and an edge case (#2162) 2025-04-22 17:52:09 -07:00
MonsterAbilities.cs feat(throwing): add Ter Mur reptiles (Raptor + slith family) and their SA claws (#2515) 2026-07-02 23:58:29 -07:00
MonsterAbility.cs refactor: Changes BaseCreature to the SerializationGenerator (delta save requirement) (#2611) 2026-09-06 14:11:51 -07:00
MonsterAbilityGroup.cs fix: Cleans up potential memory leak in monster abilities. (#2185) 2025-05-15 19:42:54 -07:00
MonsterAbilitySingleTarget.cs fix: Fixes single target abilities. Adds drain life ability. (#1276) 2022-11-23 19:06:27 -08:00
MonsterAbilitySingleTargetDoT.cs fix: Timer Remaining Count off by 1 fix (#2046) 2025-01-01 20:19:38 -08:00
MonsterAbilityTrigger.cs feat: Adds magical barrier and ebolt counter ability (#1182) 2022-10-02 20:48:53 -07:00
MonsterAbilityType.cs feat(throwing): add Ter Mur reptiles (Raptor + slith family) and their SA claws (#2515) 2026-07-02 23:58:29 -07:00
PoisonGasAreaAttack.cs feat: Adds magical barrier and ebolt counter ability (#1182) 2022-10-02 20:48:53 -07:00
PoisonGasCounter.cs fix: Fixes single target abilities. Adds drain life ability. (#1276) 2022-11-23 19:06:27 -08:00
ReflectPhysicalDamage.cs fix: Cleans up potential memory leak in monster abilities. (#2185) 2025-05-15 19:42:54 -07:00
RuneCorruption.cs fix: Fixes Dot abilities. Adds blood bath attack (#1277) 2022-11-23 19:40:48 -08:00
StunAttack.cs fix: Fixes NPE with stun attack (#1751) 2024-04-30 19:20:06 -07:00
SummonPixiesCounter.cs fix: Adds summon pixies. Fixes other abilities (#1274) 2022-11-23 17:39:23 -08:00
TailSwipe.cs feat(throwing): add Ter Mur reptiles (Raptor + slith family) and their SA claws (#2515) 2026-07-02 23:58:29 -07:00
ThrowHatchetCounter.cs fix: Fixes single target abilities. Adds drain life ability. (#1276) 2022-11-23 19:06:27 -08:00