Commit graph

312 commits

Author SHA1 Message Date
Kamron Batman
bd661da81c
fix: Fix sending blockers to GMs (#1441) 2023-08-05 19:44:47 -07:00
mdodkins
a9a2a89908
feat: Customize expansion and set maps on first boot (#1425) 2023-07-31 20:46:49 -07:00
vexyl
d6ebe67dd8
fix: Fixes untamed creatures not entering houses (#1436) 2023-07-29 15:43:39 -07:00
Kamron Batman
4dddc8d3f1
fix: Fixes NPE in BaseRanged.OnMiss (#1433) 2023-07-27 09:17:52 -07:00
Kamron Batman
f77dd91811
fix: Overhauls virtue system (#1376)
## MAJOR CHANGE (API BREAKING)

Moved the virtues to it's own system _VirtueSystem_. This should make it easier to extend or remove the virtue system. Virtues will be saved to a new folder called _Virtues_.

### Motivation

The motivation was also two-fold, performance/stability, and to fix bugs.

First, virtues is the second system (first is murders), that has a pre-world-save check on _every mobile in the game_ to atrophy virtue stats. This is taxing since it freexes the world and makes world saves take longer. Every mobile had Gain/Loss dates for each virtue, whether they needed them or not. Most players don't even use the virtue system, so this will increase performance considerably.

Second, when I tried to optimize/refactor the code, I found several bugs that needed to be fixed.

### Major API Changes

- [X] The properties on players related to virtues are gone. Use `pm.GetVirtues()?.<PropertyName>` instead.
- [X] Virtues were removed from non-player Mobiles.
- [X] `pm.JusticeProtectors` was removed. Use `JusticeVirtue.GetProtector()` or `JusticeVirtue.GetProtected()` instead.

### Screenshots

<img width="221" alt="Props-1" src="https://github.com/modernuo/ModernUO/assets/3953314/5c09cb83-b8d5-44a2-b899-a7ed7cd736ac">
<img width="220" alt="props-2" src="https://github.com/modernuo/ModernUO/assets/3953314/aeade4d3-8df0-47bd-955a-a864d0946cf7">
2023-07-19 21:43:47 -07:00
Kamron Batman
063d878276
fix: Cleans up murder system (#1428) 2023-07-16 00:04:30 -07:00
Kamron Batman
8ff105ac46
fix: Fixes NPE in boomerang (#1426) 2023-07-15 10:07:35 -07:00
Mink80
27e00cc73f
fix: Fixes spellbook not showing SpellCount when added non-empty. (#1424) 2023-07-04 16:14:04 -07:00
Kamron Batman
3b97e8d39c
fix: Fixes stabled, abilities targeting self, and unsummon memory leak (#1418)
## **MAJOR CHANGE**
* `Stabled` has been moved to `PlayerMobile`.
* New methods added, `PlayerMobile.AddStabled` and `PlayerMobile.RemoveStabled`.
* Added `PlayerMobile.AddFollower` and `PlayerMobile.RemoveFollower`.
* `Stabled`, `AutoStabled`, and `AllFollowers` are now `HashSet` and **_CAN BE NULL_**.

### Summary
* Fixes monster abilities causing harm to the monster through reflect
* Adds `CanTriggerAgainstSelf` to override this for healing or some other self-affecting ability
* Fixes a major memory leak where `UnsummonTimer` from animated dead spell lasts up-to 24hrs and therefore holds onto references of dead/deleted mobs.
* Fixes another minor leak where a mob is not unregistered from the animated dead spell list until the next spell cast.
2023-07-03 09:45:22 -07:00
Kamron Batman
f2d0f6616e
fix: Fixes NPE with effect controller (#1406) 2023-05-21 23:29:16 -07:00
Kamron Batman
35237ff7d1
fix: Fixes leaking/errors caused by categorization (#1404)
### Summary
- [X] Fixes 4 TormentedMinotaur created at `(0, 0, 0) [null]` when `[add` is used.
- [X] Fixes client crash from a bug in HouseRaffleStone when `[add` is used.

Recommend viewing with [_whitespace disabled_](https://github.com/modernuo/ModernUO/pull/1404/files?diff=split&w=1)
2023-05-19 18:41:31 -07:00
mark1145
55dc4a7da5
fix: Fixes casting by sending ParalyzeFlag to client while animating (#1397) 2023-04-27 23:12:07 -07:00
Kamron Batman
ba4c4627c3
fix: Fixes the limitation on static tiles for harvesting (#1396)
* fix: Fixes the limitation on static tiles for harvesting

* Fixes dirt targeting
2023-04-22 09:14:42 -07:00
Kamron Batman
79c6f0375c
fix: Fixes doors as decorations & optimizes them (#1392) 2023-04-18 19:28:54 -07:00
Kamron Batman
6c09e5a006
fix: Fixes infinite loop in bulletin board cleanup (#1394) 2023-04-18 19:27:40 -07:00
romanlysenko
3c86af4ff3
fix: Removes duplicate CheckTransform static method (#1384) 2023-04-03 23:03:40 -07:00
romanlysenko
5c6525de46
fix: Removes duplicate UnderTransformation static method (#1383) 2023-04-03 22:07:12 -07:00
Kamron Batman
e08efad9be
fix: Updates messages with clilocs (#1381) 2023-03-26 00:54:09 -07:00
Kamron Batman
127ca5e51e
fix: Fixes veteran rewards (#1374)
### Summary
- [X] Fixes a bug in wall banner East setter: [[ServerUO#5046]](https://github.com/ServUO/ServUO/pull/5046)
- [X] Eliminates the timer in tree stump.
- [X] Codegens the rewards
2023-03-12 17:28:51 -07:00
Kamron Batman
e797ec7f53
fix: Fixes special scrolls (#1373) 2023-03-12 13:47:12 -07:00
Kamron Batman
6fcd606947
fix: Codegens rares and solen items (#1371) 2023-03-11 19:25:48 -08:00
Kamron Batman
3514651c3c
fix: Codegens mutation core (#1370) 2023-03-11 17:33:31 -08:00
Kamron Batman
f8ab7cfdf8
fix: Optimizes timer in house raffle stone (#1369) 2023-03-11 12:37:40 -08:00
Kamron Batman
0645251ec7
fix: Fixes scales, heritage items, and codegens holiday items (#1365) 2023-03-07 22:38:35 -08:00
Kamron Batman
f1e8d4c6f7
fix: Codegens heritage items (#1364) 2023-03-07 21:29:13 -08:00
Kamron Batman
82b5fa6af3
fix: Codegens gifts (#1363) 2023-03-07 21:07:45 -08:00
Kamron Batman
551f6cca9d
fix: Codegens evil decor. Fixes trash items (#1362) 2023-03-06 19:28:58 -08:00
Kamron Batman
84b3e5cfdb
fix: Codegens BOD rewards. (#1361) 2023-03-06 19:01:14 -08:00
Kamron Batman
3097eb4fa7
fix: Fixes Dice Infinite loop and deserialization of some items (#1360)
### Summary
- Fixes deserialization issues with some items.
- Changes Utility.Dice to prevent long iteration by passing `(uint)-1`
2023-03-05 18:29:48 -08:00
Kamron Batman
9b6aa1deed
fix: Fixes missed codegen for potions (#1359) 2023-03-02 21:27:42 -08:00
Kamron Batman
0150e1a994
fix: Fixes broken chair (#1356) 2023-02-27 09:01:50 -08:00
Kamron Batman
8e3facc57b
fix: Codegens promo items (#1355) 2023-02-26 00:48:27 -08:00
Kamron Batman
bf6da39176
fix: Codegens tools (#1354) 2023-02-25 13:54:05 -08:00
Kamron Batman
d14e864c85
fix: Updates disguises and codegens tinkering items (#1353) 2023-02-25 12:01:06 -08:00
Kamron Batman
f2fdc0321c
fix: Localizes specialized books, codegens instruments (#1352) 2023-02-25 10:56:05 -08:00
Kamron Batman
42012538bc
fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
Kamron Batman
10b26741c7
fix: Codegens spellbooks (#1349) 2023-02-24 19:04:21 -08:00
Kamron Batman
8e49fb4da4
fix: Codegens scrolls (#1348) 2023-02-24 18:17:29 -08:00
Kamron Batman
8c4aaeeda6
fix: Codegens potions and fixes a few minor bugs (#1347) 2023-02-24 18:06:59 -08:00
Kamron Batman
65c196a8ae
fix: Fixes Point2D ctor (#1340) 2023-02-13 23:28:23 -08:00
Kamron Batman
f24c6a08dd
fix: Fixes string interpolation in value string builder (#1339) 2023-02-13 23:09:50 -08:00
Kamron Batman
3cf6db73f0
fix: Fixes provocation for pre-pub 16 (#1335) 2023-02-07 23:33:45 -08:00
Kamron Batman
982058c224
fix: Fixes weapon proc on 0 damage (#1324)
Weapons should not proc their abilities on 0 damage given.
2023-01-28 10:39:19 -08:00
Kamron Batman
b18dfcbb63
fix: Simplifies ore stack logic (#1319) 2023-01-03 18:07:42 -08:00
Kamron Batman
e855ca1e61
fix: Removes PoolOfAcid (#1310)
## BREAKING CHANGES
You will receive a deserialization error saying cannot find type PoolOfAcid. This is ok, just hit yes to delete all.
2022-12-22 13:20:34 -08:00
Kamron Batman
7a1d5131c8
fix: Smooths out throwing explosion potions (#1303)
* Fix: The potion explodes on the user if it is thrown with not enough time. Instead, the timer is stopped, and the potion explodes instantly at the target location.
* Fix: When the potion appears based on how far you throw it.
* Fix: Fixes total timer amount of time.
2022-12-19 14:44:07 -08:00
Kamron Batman
899c2e868d
fix: Codegens tools and magical skill items (#1299) 2022-12-07 20:46:41 -08:00
Kamron Batman
1745faa28c
fix: Fixes divine fury (#1290) 2022-12-04 12:39:30 -08:00
Kamron Batman
81839beedd
fix: Removes serial ctor that isnt needed (#1289) 2022-11-28 23:48:46 -08:00
Kamron Batman
af29fa0243
fix: Codegens fishing pole (#1288) 2022-11-28 23:42:32 -08:00